Merge pull request #20 from lushonline/19-fix-undefined-variable-$required-in-web-services-api

19 fix undefined variable $required in web services api

Author: lushonline

.github/workflows/ci.yml

@@ -21,7 +21,7 @@ jobs:
 
     services:
       postgres:
-        image: postgres:12
+        image: postgres:13
         env:
           POSTGRES_USER: "postgres"
           POSTGRES_HOST_AUTH_METHOD: "trust"

classes/external.php

@@ -190,10 +190,10 @@ public static function get_externalcontents_by_courses_returns() {
                             'course' => new external_value(PARAM_INT, 'Course id'),
                             'name' => new external_value(PARAM_RAW, 'externalcontent name'),
                             'intro' => new external_value(PARAM_RAW, 'Summary'),
-                            'introformat' => new external_format_value('intro', 'Summary format'),
+                            'introformat' => new external_format_value('intro', VALUE_REQUIRED, 'Summary format'),
                             'introfiles' => new external_files('Files in the introduction text'),
                             'content' => new external_value(PARAM_RAW, 'External content content'),
-                            'contentformat' => new external_format_value('content', 'Content format'),
+                            'contentformat' => new external_format_value('content', VALUE_REQUIRED, 'Content format'),
                             'contentfiles' => new external_files('Files in the content'),
                             'displayoptions' => new external_value(PARAM_RAW, 'Display options'),
                             'timemodified' => new external_value(PARAM_INT, 'Last time the externalcontent was modified'),

version.php

@@ -24,7 +24,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version = 2023031400;
+$plugin->version = 2023072400;
 $plugin->requires = 2021051700; // Requires this Moodle version v3.11 see https://docs.moodle.org/dev/Releases.
 $plugin->component = 'mod_externalcontent';
 $plugin->maturity = MATURITY_STABLE;