Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete button directive-params are overriden by state-params #535

Closed
vasiakorobkin opened this issue Jun 30, 2015 · 1 comment
Closed

Delete button directive-params are overriden by state-params #535

vasiakorobkin opened this issue Jun 30, 2015 · 1 comment

Comments

@vasiakorobkin
Copy link

Here you can see that directive params (entity and id) are always overriden with state params (entry and id from object which is returned from $state.params call).
In practice it causes wrong behaviour whenever we try to place Delete button in other entity's view. For example I have Post which may have many Images and use referenced_list field type to view list of related Images in Post's edit view. If i place <ma-delete-button entry="::entry" entity="::entity()" size="xs"></ma-delete-button> directive to the refernced_list table (as template field type), delete button will direct user to the Post deletion view, not Image deletion view. This is a bug, and I've made a fix for it: vasiakorobkin/ng-admin@2534ba3

@jpetitcolas
Copy link
Contributor

Fixed by #642.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants