We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marp for VS Code v3.1.0
macOS
OS version: macOS Sequoia 15.3.1 VS Code version (Marp for VS Code): VS Code 1.97.2
🐣
Show a slide page with the content 🐣
A slide page has incorrect encoding.
Originally reported in marp-team/marp#558.
Extension could not deal with that due to lack of VS Code API for getting a encoding for the current document. But now the latest VS Code 1.98 has a newly proposed API for getting encoding. https://code.visualstudio.com/updates/v1_98#_text-encodings https://github.com/microsoft/vscode/blob/501ee833b16b8e83ba656c46e0888aadd9d2db04/src/vscode-dts/vscode.proposed.textDocumentEncoding.d.ts#L1
To fix that, Marp for VS Code should use an temporary file as an input if detected non UTF-8 encoding.
marp-vscode/src/marp-cli.ts
Line 30 in bc09bd5
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Version of Marp Tool
Marp for VS Code v3.1.0
Operating System
macOS
Environment
OS version: macOS Sequoia 15.3.1
VS Code version (Marp for VS Code): VS Code 1.97.2
How to reproduce
Expected behavior
Show a slide page with the content
🐣
Actual behavior
A slide page has incorrect encoding.
Additional information
Originally reported in marp-team/marp#558.
Extension could not deal with that due to lack of VS Code API for getting a encoding for the current document. But now the latest VS Code 1.98 has a newly proposed API for getting encoding.
https://code.visualstudio.com/updates/v1_98#_text-encodings
https://github.com/microsoft/vscode/blob/501ee833b16b8e83ba656c46e0888aadd9d2db04/src/vscode-dts/vscode.proposed.textDocumentEncoding.d.ts#L1
To fix that, Marp for VS Code should use an temporary file as an input if detected non UTF-8 encoding.
marp-vscode/src/marp-cli.ts
Line 30 in bc09bd5
The text was updated successfully, but these errors were encountered: