Skip to content

Commit 104ce8b

Browse files
authored
Rollup merge of rust-lang#122567 - erikdesjardins:noname, r=oli-obk
Remove fixme about LLVM basic block naming ~This may be a small perf win.~ Originally, this PR implemented the fixme, but it didn't have any measurable perf improvement. r? `@ghost`
2 parents 6aca2ab + a7d4258 commit 104ce8b

File tree

1 file changed

+0
-1
lines changed
  • compiler/rustc_codegen_ssa/src/mir

1 file changed

+0
-1
lines changed

compiler/rustc_codegen_ssa/src/mir/block.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1688,7 +1688,6 @@ impl<'a, 'tcx, Bx: BuilderMethods<'a, 'tcx>> FunctionCx<'a, 'tcx, Bx> {
16881688
pub fn try_llbb(&mut self, bb: mir::BasicBlock) -> Option<Bx::BasicBlock> {
16891689
match self.cached_llbbs[bb] {
16901690
CachedLlbb::None => {
1691-
// FIXME(eddyb) only name the block if `fewer_names` is `false`.
16921691
let llbb = Bx::append_block(self.cx, self.llfn, &format!("{bb:?}"));
16931692
self.cached_llbbs[bb] = CachedLlbb::Some(llbb);
16941693
Some(llbb)

0 commit comments

Comments
 (0)