Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace exlicit IDs on headings with Yari generated versions #434

Closed
nschonni opened this issue Dec 18, 2020 · 1 comment
Closed

Replace exlicit IDs on headings with Yari generated versions #434

nschonni opened this issue Dec 18, 2020 · 1 comment
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@nschonni
Copy link
Contributor

Notice there are some duplicate IDs from old wiki copy/paste and also some invalid ID values. If there current ones are stripped off and added by Yari during the build (correctly escaped), this would probably give a more consistent experience.

Downsides to this would be that old anchors would get broken as the heading text changes, but this probably happens already.

@Rumyra Rumyra added needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. enhancement labels Jun 7, 2021
@sideshowbarker
Copy link
Member

I think this has already been dealt with through changes made to Yari after December when this was raised. So I’m going ahead and closing this, with a heads-up to @mdn/core.

But if I’m mistaken, of course this could be re-opened and revisited.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Development

No branches or pull requests

3 participants