-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out a solution for storing image source files #1678
Comments
There's nothing stopping you from putting those into the folder next to the I don't think we need to worry too much about a naming convention just yet. What might be confusing is that you might not quickly be able to see if In terms of naming, we haven't been perfect, but we try to use the |
By the way, I think we should transfer this issue to mdn/yari since it's not actually about the written content :) |
From personal experience I can tell, that once a git repo approaches the ~4 GiB limit, you'll run into troubles. |
So maybe we could use a directory called
Hrm, I wonder how quickly we'd start to run into such problems! Maybe a better solution would be to store the source files in a different repo... |
And we can do lo-fi solutions like creating a file called You're also free to use HTML comments within the text itself. Like: <p>Lorem ipsum...<p>
<!-- Sources generating these PNGs are in https://github.com/mdn/chart-diagrams-draw.io -->
<img src="diagram.png" alt="Chart diagram"> |
@peterbe @Ryuno-Ki Continuing discuss from #3652 (comment) Peter, yes, compressing files is highly desirable, and my justification for not compressing the SVG was flawed as I can still edit the SVG very nicely in inkscape even following it's compression. Note however that the compressed SVG is bigger than the equivalent file as a PNG, which is in turn bigger than a compressed JPG. Some might argue that we should therefore always save the file as a jpg. To me the convenience of having the source editable as SVG is well worth it. I think this should at least be considered as part of our "solution" to the problem. The other "solution" is to store sources elsewhere and have an easy way to locate and manage them. That might be a simple as HTML comment alongside the image (which is what I normally do), a searchable database, or a github repo that duplicates the structure and filename so you can easily locate the source. The benefit of SVG over all of these is that things is that you don't have to separately manage your files - e.g. manage who has access, or keeping structures up to date. |
@fiji-flo Is this still an issue? |
Mostly it is a "question". It hasn't been fixed or discussed so IMO is still relevant. |
Reading the comments, my question is: if I add an "original" file (like a Photoshop one) next to the If not, we should just store them along. (and update the meta-docs hinting at clear names like |
Yeah, that could work. Or you could argue that we should use SVG by default or some online editor or "whatever". I'm good with whatever as long as we have thought about it and agreed a general pattern. |
This sounds like a discussion to me :) Which of the categories here do you think would be most appropriate? Content, platform? |
Content :-) |
Closing in favor of the following discussion: mdn/mdn-community#94 - Please add your suggestions and recommendation in the new discussion. Thank you, everyone! |
One of our contributors mentioned that it'd be really good to have a place to store image source files, e.g. the raw SVG or draw.io source version of the final image shown on an article, so that if it needs to be edited later on, the source version can be easily found.
Could we just start including an
img-source
folder in the Yari article folders? Would be good to discuss this at some point.The text was updated successfully, but these errors were encountered: