Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a couple of bugs in sctp.c #2426

Closed
afshin2003 opened this issue Nov 8, 2020 · 3 comments
Closed

Fixing a couple of bugs in sctp.c #2426

afshin2003 opened this issue Nov 8, 2020 · 3 comments

Comments

@afshin2003
Copy link
Contributor

Hi Guys,
There were a couple of bugs in sctp.c which fixed by me :)

  1. In janus_sctp_pending_message_create the len attribute was not set properly.
  2. In the burst transfers, packets got stuck in pending_messages queue!. To fix this the new function janus_sctp_data_ready is called in case of SCTP_SENDER_DRY_EVENT. I moved the first loop of janus_sctp_send_data function to the new created function to push pending messages to sctp stack. At the end of function I called the janus_dtls_sctp_data_ready function.

Hope to merge soon,

sctp.c.txt

@lminiero
Copy link
Member

lminiero commented Nov 8, 2020

Please submit a pull request, not raw files.

@afshin2003
Copy link
Contributor Author

Done!
It was the first time that I pulled a request :)

@atoppi
Copy link
Member

atoppi commented Nov 26, 2020

Closing since #2427 has been merged.
Thanks again!

@atoppi atoppi closed this as completed Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants