Skip to content

Commit 85ce310

Browse files
committed
rework contains geometry to avoid clipping
1 parent fac570c commit 85ce310

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

packages/mermaid/src/diagrams/requirement/requirementDb.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,8 @@ export class RequirementDB implements DiagramDB {
328328
thickness: 'normal',
329329
type: 'normal',
330330
pattern: isContains ? 'normal' : 'dashed',
331-
arrowhead: isContains ? 'requirement_contains' : 'requirement_arrow',
331+
arrowTypeStart: isContains ? 'requirement_contains' : '',
332+
arrowTypeEnd: isContains ? '' : 'requirement_arrow',
332333
look: config.look,
333334
};
334335

packages/mermaid/src/rendering-util/rendering-elements/markers.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -423,19 +423,19 @@ const requirement_contains = (elem, type, id) => {
423423
const containsNode = elem
424424
.append('defs')
425425
.append('marker')
426-
.attr('id', id + '_' + type + '-requirement_containsEnd')
427-
.attr('refX', 20)
426+
.attr('id', id + '_' + type + '-requirement_containsStart')
427+
.attr('refX', 0)
428428
.attr('refY', 10)
429429
.attr('markerWidth', 20)
430430
.attr('markerHeight', 20)
431431
.attr('orient', 'auto')
432432
.append('g');
433433

434-
containsNode.append('circle').attr('cx', 10).attr('cy', 10).attr('r', 10).attr('fill', 'none');
434+
containsNode.append('circle').attr('cx', 10).attr('cy', 10).attr('r', 9).attr('fill', 'none');
435435

436-
containsNode.append('line').attr('x1', 0).attr('x2', 20).attr('y1', 10).attr('y2', 10);
436+
containsNode.append('line').attr('x1', 1).attr('x2', 19).attr('y1', 10).attr('y2', 10);
437437

438-
containsNode.append('line').attr('y1', 0).attr('y2', 20).attr('x1', 10).attr('x2', 10);
438+
containsNode.append('line').attr('y1', 1).attr('y2', 19).attr('x1', 10).attr('x2', 10);
439439
};
440440

441441
// TODO rename the class diagram markers to something shape descriptive and semantic free

0 commit comments

Comments
 (0)