Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill doesn't seem to work for ER Diagrams #3711

Closed
xMarcinator opened this issue Oct 23, 2022 · 1 comment · Fixed by #3719 or #3722
Closed

Fill doesn't seem to work for ER Diagrams #3711

xMarcinator opened this issue Oct 23, 2022 · 1 comment · Fixed by #3719 or #3722
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@xMarcinator
Copy link

Describe the bug
The fill config for the ER Diagram seems to not be applied

To Reproduce
Set ER diagram fill config though a directive or in config

Expected behavior
Expected behavior was for the background of an attribute

Screenshots
If applicable, add screenshots to help explain your problem.


image

Code Sample
Link to live editor

Desktop (please complete the following information):

  • OS: Windows (64-bit)
  • Browser Firefox
  • Version 106.0.1 (64-bit)

Additional context
Link to the config file where the behavior of fill is defined

@xMarcinator xMarcinator added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Oct 23, 2022
@CalebUsadi
Copy link
Contributor

CalebUsadi commented Oct 25, 2022

I can help with this. The fill is being set as an attribute rather than as a style in the erRenderer.js file, and is being overridden by subsequent CSS. I have made a small fix which doesn't break anything. I don't know though which of the sections is supposed to be filled with the defined color. If this seems unproblematic, I can go through and make the changes uniform. According to the SVG specification it's not possible to add an !important declaration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
2 participants