Skip to content

Commit ce0e522

Browse files
Trottandrew749
authored andcommitted
test: add coverage for child_process bounds check
Make sure that monkey-patching process.execArgv doesn't cause child_process to incorrectly munge execArgv in fork(). This basically is adding coverage for an `index > 0` check (see Refs). Previously, that condition was never false in any of the tests. PR-URL: nodejs/node#11800 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Refs: https://github.com/nodejs/node/blob/c67207731f16a78f6cae90e49c53b10728241ecf/lib/child_process.js#L76
1 parent 5731206 commit ce0e522

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

test/parallel/test-cli-eval.js

+11
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,17 @@ child.exec(`${nodejs} --use-strict -p process.execArgv`,
117117
assert.strictEqual(stdout, '');
118118
assert.strictEqual(stderr, '');
119119
}));
120+
121+
// Make sure that monkey-patching process.execArgv doesn't cause child_process
122+
// to incorrectly munge execArgv.
123+
child.exec(
124+
`${nodejs} -e "process.execArgv = ['-e', 'console.log(42)', 'thirdArg'];` +
125+
`require('child_process').fork('${emptyFile}')"`,
126+
common.mustCall((err, stdout, stderr) => {
127+
assert.ifError(err);
128+
assert.strictEqual(stdout, '42\n');
129+
assert.strictEqual(stderr, '');
130+
}));
120131
}
121132

122133
// Regression test for https://github.com/nodejs/node/issues/8534.

0 commit comments

Comments
 (0)