unittest discovery errors not displaying in test explorer (#21726)

eleanorjboyd · web-flow · commit 8f3d60bf378a · 2023-08-01T14:32:44.000-07:00
saw an issue where if discovery failed there was no notice in the test explorer for unittest. It was due to a different value for the new blank value for the payload tests. fixes #21725 and #21688
diff --git a/src/client/testing/testController/common/resultResolver.ts b/src/client/testing/testController/common/resultResolver.ts
@@ -68,7 +68,7 @@ export class PythonResultResolver implements ITestResultResolver {
             // remove error node only if no errors exist.
             this.testController.items.delete(`DiscoveryError:${workspacePath}`);
         }
-        if (rawTestData.tests) {
+        if (rawTestData.tests || rawTestData.tests === null) {
             // if any tests exist, they should be populated in the test tree, regardless of whether there were errors or not.
             // parse and insert test data.
 

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ export class PythonResultResolver implements ITestResultResolver {`
`68`	`68`	`// remove error node only if no errors exist.`
`69`	`69`	this.testController.items.delete(`DiscoveryError:${workspacePath}`);
`70`	`70`	`}`
`71`		`- if (rawTestData.tests) {`
	`71`	`+ if (rawTestData.tests \|\| rawTestData.tests === null) {`
`72`	`72`	`// if any tests exist, they should be populated in the test tree, regardless of whether there were errors or not.`
`73`	`73`	`// parse and insert test data.`
`74`	`74`