Skip to content

Commit b43378e

Browse files
committed
notebook tests - run verbose (#165149)
1 parent d0e44be commit b43378e

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

extensions/vscode-api-tests/src/singlefolder-tests/notebook.editor.test.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import * as assert from 'assert';
77
import * as vscode from 'vscode';
88
import * as utils from '../utils';
99

10-
(vscode.env.uiKind === vscode.UIKind.Web ? suite.skip : suite.skip)('Notebook Editor', function () {
10+
(vscode.env.uiKind === vscode.UIKind.Web ? suite.skip : suite)('Notebook Editor', function () {
1111

1212
const contentSerializer = new class implements vscode.NotebookSerializer {
1313
deserializeNotebook() {
@@ -66,14 +66,14 @@ import * as utils from '../utils';
6666
});
6767

6868
// #138683
69-
test('Opening a notebook should fire activeNotebook event changed only once', async function () {
69+
test('Opening a notebook should fire activeNotebook event changed only once', utils.withVerboseLogs(async function () {
7070
const openedEditor = onDidOpenNotebookEditor();
7171
const resource = await utils.createRandomFile(undefined, undefined, '.nbdtest');
7272
const document = await vscode.workspace.openNotebookDocument(resource);
7373
const editor = await vscode.window.showNotebookDocument(document);
7474
assert.ok(await openedEditor);
7575
assert.strictEqual(editor.notebook.uri.toString(), resource.toString());
76-
});
76+
}));
7777

7878
test('Active/Visible Editor', async function () {
7979
const firstEditorOpen = onDidOpenNotebookEditor();

extensions/vscode-api-tests/src/utils.ts

+10-2
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,10 @@ export function delay(ms: number) {
6666
return new Promise(resolve => setTimeout(resolve, ms));
6767
}
6868

69-
export function withLogDisabled(runnable: () => Promise<any>): () => Promise<void> {
69+
function withLogLevel(level: string, runnable: () => Promise<any>): () => Promise<void> {
7070
return async (): Promise<void> => {
7171
const logLevel = await vscode.commands.executeCommand('_extensionTests.getLogLevel');
72-
await vscode.commands.executeCommand('_extensionTests.setLogLevel', 'off');
72+
await vscode.commands.executeCommand('_extensionTests.setLogLevel', level);
7373

7474
try {
7575
await runnable();
@@ -79,6 +79,14 @@ export function withLogDisabled(runnable: () => Promise<any>): () => Promise<voi
7979
};
8080
}
8181

82+
export function withLogDisabled(runnable: () => Promise<any>): () => Promise<void> {
83+
return withLogLevel('off', runnable);
84+
}
85+
86+
export function withVerboseLogs(runnable: () => Promise<any>): () => Promise<void> {
87+
return withLogLevel('trace', runnable);
88+
}
89+
8290
export function assertNoRpc() {
8391
assertNoRpcFromEntry([vscode, 'vscode']);
8492
}

0 commit comments

Comments
 (0)