Skip to content

Commit d0182c3

Browse files
committed
Only track first time installs for recommended extensions #49583
1 parent be4c738 commit d0182c3

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/vs/workbench/parts/extensions/node/extensionsWorkbenchService.ts

+3-4
Original file line numberDiff line numberDiff line change
@@ -799,18 +799,17 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService,
799799
const extension: Extension = installingExtension ? installingExtension : zipPath ? new Extension(this.galleryService, this.stateProvider, null, null, this.telemetryService) : null;
800800
if (extension) {
801801
this.installing = installingExtension ? this.installing.filter(e => e !== installingExtension) : this.installing;
802-
802+
const installed = this.installed.filter(e => e.id === extension.id)[0];
803803
if (!error) {
804804
extension.local = local;
805-
const installed = this.installed.filter(e => e.id === extension.id)[0];
806805
if (installed) {
807806
installed.local = local;
808807
} else {
809808
this.installed.push(extension);
810809
}
811810
}
812-
if (extension.gallery) {
813-
// Report telemetry only for gallery extensions
811+
if (extension.gallery && !installed) {
812+
// Report recommendation telemetry only for gallery extensions that are first time installs
814813
this.reportExtensionRecommendationsTelemetry(installingExtension);
815814
}
816815
}

0 commit comments

Comments
 (0)