Fix unsafe type assertions

Part of #211878

Author: Tyriar

src/vs/workbench/contrib/terminal/browser/terminalExtensions.ts

@@ -22,6 +22,7 @@ export type ITerminalContributionDescription = { readonly id: string } & (
 export function registerTerminalContribution<Services extends BrandedService[]>(id: string, ctor: { new(instance: ITerminalInstance, processManager: ITerminalProcessManager, widgetManager: TerminalWidgetManager, ...services: Services): ITerminalContribution }, canRunInDetachedTerminals?: false): void;
 export function registerTerminalContribution<Services extends BrandedService[]>(id: string, ctor: { new(instance: ITerminalInstance, processManager: ITerminalProcessInfo, widgetManager: TerminalWidgetManager, ...services: Services): ITerminalContribution }, canRunInDetachedTerminals: true): void;
 export function registerTerminalContribution<Services extends BrandedService[]>(id: string, ctor: { new(instance: ITerminalInstance, processManager: ITerminalProcessManager, widgetManager: TerminalWidgetManager, ...services: Services): ITerminalContribution }, canRunInDetachedTerminals = false): void {
+	// eslint-disable-next-line local/code-no-dangerous-type-assertions
 	TerminalContributionRegistry.INSTANCE.registerTerminalContribution({ id, ctor, canRunInDetachedTerminals } as ITerminalContributionDescription);
 }
 

src/vs/workbench/contrib/terminal/browser/terminalInstance.ts

@@ -993,7 +993,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
 								run: () => {
 									this._preferencesService.openSettings({ jsonEditor: false, query: `@id:${TerminalSettingId.CommandsToSkipShell},${TerminalSettingId.SendKeybindingsToShell},${TerminalSettingId.AllowChords}` });
 								}
-							} as IPromptChoice
+							} satisfies IPromptChoice
 						]
 					);
 					this._storageService.store(SHOW_TERMINAL_CONFIG_PROMPT_KEY, false, StorageScope.APPLICATION, StorageTarget.USER);

src/vs/workbench/contrib/terminal/browser/terminalView.ts

@@ -446,7 +446,7 @@ class SingleTerminalTabActionViewItem extends MenuEntryActionViewItem {
 	override async onClick(event: MouseEvent): Promise<void> {
 		this._terminalGroupService.lastAccessedMenu = 'inline-tab';
 		if (event.altKey && this._menuItemAction.alt) {
-			this._commandService.executeCommand(this._menuItemAction.alt.id, { target: TerminalLocation.Panel } as ICreateTerminalOptions);
+			this._commandService.executeCommand(this._menuItemAction.alt.id, { location: TerminalLocation.Panel } satisfies ICreateTerminalOptions);
 		} else {
 			this._openContextMenu();
 		}

src/vs/workbench/contrib/terminal/test/browser/terminalProfileService.integrationTest.ts

@@ -107,7 +107,7 @@ class TestTerminalInstanceService implements Partial<ITerminalInstanceService> {
 					return [];
 				}
 			}
-		} as Partial<ITerminalBackend> as any;
+		} satisfies Partial<ITerminalBackend> as any;
 	}
 	setProfiles(remoteAuthority: string | undefined, profiles: ITerminalProfile[]) {
 		this._profiles.set(remoteAuthority ?? '', profiles);
@@ -123,7 +123,7 @@ class TestRemoteAgentService implements Partial<IRemoteAgentService> {
 		this._os = os;
 	}
 	async getEnvironment(): Promise<IRemoteAgentEnvironment | null> {
-		return { os: this._os } as IRemoteAgentEnvironment;
+		return { os: this._os } satisfies Partial<IRemoteAgentEnvironment> as any;
 	}
 }
 
@@ -167,7 +167,7 @@ suite('TerminalProfileService', () => {
 		remoteAgentService = new TestRemoteAgentService();
 		terminalInstanceService = new TestTerminalInstanceService();
 		extensionService = new TestTerminalExtensionService();
-		environmentService = { remoteAuthority: undefined } as IWorkbenchEnvironmentService;
+		environmentService = { remoteAuthority: undefined } satisfies Partial<IWorkbenchEnvironmentService> as any;
 
 		const themeService = new TestThemeService();
 		const terminalContributionService = new TestTerminalContributionService();
@@ -266,7 +266,7 @@ suite('TerminalProfileService', () => {
 	});
 
 	test('should get profiles from remoteTerminalService when there is a remote authority', async () => {
-		environmentService = { remoteAuthority: 'fakeremote' } as IWorkbenchEnvironmentService;
+		environmentService = { remoteAuthority: 'fakeremote' } satisfies Partial<IWorkbenchEnvironmentService> as any;
 		instantiationService.stub(IWorkbenchEnvironmentService, environmentService);
 		terminalProfileService = store.add(instantiationService.createInstance(TestTerminalProfileService));
 		await terminalProfileService.hasRefreshedProfiles;

src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts

@@ -371,7 +371,7 @@ registerTerminalAction({
 	},
 	run: (c, accessor) => {
 		const accessibleViewService = accessor.get(IAccessibleViewService);
-		accessibleViewService.setPosition({ lineNumber: 1, column: 1 } as Position, true);
+		accessibleViewService.setPosition(new Position(1, 1), true);
 	}
 });
 

src/vs/workbench/contrib/terminalContrib/quickFix/browser/quickFixAddon.ts

@@ -118,19 +118,15 @@ export class TerminalQuickFixAddon extends Disposable implements ITerminalAddon,
 			return;
 		}
 
-		// TODO: What's documentation do? Need a vscode command?
 		const actions = this._currentRenderContext.quickFixes.map(f => new TerminalQuickFixItem(f, f.type, f.source, f.label, f.kind));
-		const documentation = this._currentRenderContext.quickFixes.map(f => { return { id: f.source, title: f.label, tooltip: f.source }; });
 		const actionSet = {
-			// TODO: Documentation and actions are separate?
-			documentation,
 			allActions: actions,
 			hasAutoFix: false,
 			hasAIFix: false,
 			allAIFixes: false,
 			validActions: actions,
 			dispose: () => { }
-		} as ActionSet<TerminalQuickFixItem>;
+		} satisfies ActionSet<TerminalQuickFixItem>;
 		const delegate = {
 			onSelect: async (fix: TerminalQuickFixItem) => {
 				fix.action?.run();