-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Terminal process revive #133516
Comments
I'm not clear on what "buffer" and "terminal process" means from user's perspective, can you clarify? An example of a process I can launch, or how to "fill the buffer" would help. For me as long as |
@karrtikr sorry for the confusion. buffer just means terminal input and output |
Refs: #131634, #133512
Complexity: 4
Authors: @Tyriar, @meganrogge
Roles: Developer, Engineering Manager
Create Issue
When terminal processes are torn down when shutting down a window or the application it's now possible to store the buffer contents, restore it and "revive" the terminal process. The way this works is when closing a window it's evaluated whether this should persist, if so all relevant details are stored to disk and then when the same workspace is loaded, when the pty host connection is established the old processes are re-launched and then reconnected to using the same mechanism that regular process reconnection on window reload uses.
The settings that drive this feature:
terminal.integrated.persistentSessionReviveProcess
: Whether to revive on application exit, window close or disable.terminal.integrated.persistentSessionScrollback
: The amount of buffer data to storeHere are some test cases to get you started:
terminal.integrated.persistentSessionReviveProcess
setting valuevim
ortmux
) and trigger process revive, the alt buffer should not be restored but whatever was in the normal buffer before opening vim should be. Note that on Windows this can end off looking wrong due to how conpty works for example the below shows a revive of a terminal with the process tree pwsh -> wsl -> vim:We cannot easily detect this case though so it's by design currently.
terminal.integrated.persistentSessionScrollback
settingupdate.mode
). Note regular process reconnect can't work here because the whole application is taken down in case the setting change affects the main/shared proc.The text was updated successfully, but these errors were encountered: