Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Terminal smooth scrolling #158826

Closed
3 tasks done
Tyriar opened this issue Aug 22, 2022 · 6 comments
Closed
3 tasks done

Test: Terminal smooth scrolling #158826

Tyriar opened this issue Aug 22, 2022 · 6 comments

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 22, 2022

Refs: #125950

Complexity: 1

Authors: @meganrogge @Tyriar

Create Issue


The terminal now features smooth scrolling like in the editor. To test, enable "terminal.integrated.smoothScrolling": true and see if it acts like the editor.

Note that it's expected that all rows in the terminal are still "snapped" to the grid.

@Tyriar Tyriar added this to the August 2022 milestone Aug 22, 2022
@ghost ghost assigned lszomoru, luabud and sadasant Aug 23, 2022
@lszomoru
Copy link
Member

@Tyriar, should the terminal match the editor when it comes to page up/page down, as well as jumping between search results? Even though I have enabled the setting, reloaded the window, the experience for these two scenarios does not match the editor. Happy to get on a call and screen share if you want.

@Tyriar
Copy link
Member Author

Tyriar commented Aug 23, 2022

@lszomoru yes it should, that's a bug. Could you create an issue? I suppose ctrl/cmd+up/down is similar to jumping to definition so it should also animate scroll

@sadasant
Copy link

sadasant commented Aug 23, 2022

Works on Linux!

The frame rate is a bit choppy since I'm connected through Remote Desktop, but I did feel the difference.

smoothScrolling.mov

@luabud
Copy link
Member

luabud commented Aug 23, 2022

I'm not able to notice a difference between it being true or false, but it doesn't mean it isn't working 😅 I'm happy to record a GIF with more or less movements if that would help?

TerminalScrollTP1588262

@Tyriar
Copy link
Member Author

Tyriar commented Aug 23, 2022

@luabud when it's off, scrolling should "snap" immediately to the row, otherwise it would animate the scroll over 125ms. If you're using a scroll pad instead of a mouse it's much harder to notice as scroll pads have a feature called "ballistic scrolling" which does something similar already

@luabud luabud removed their assignment Aug 23, 2022
@luabud
Copy link
Member

luabud commented Aug 23, 2022

@Tyriar ahh that makes sense, thank you! I was indeed using a scroll pad. I tested with the mouse now and was able to notice the difference.

@luabud luabud closed this as completed Aug 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants