-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Terminal smooth scrolling #158826
Comments
@Tyriar, should the terminal match the editor when it comes to page up/page down, as well as jumping between search results? Even though I have enabled the setting, reloaded the window, the experience for these two scenarios does not match the editor. Happy to get on a call and screen share if you want. |
@lszomoru yes it should, that's a bug. Could you create an issue? I suppose ctrl/cmd+up/down is similar to jumping to definition so it should also animate scroll |
Works on Linux! The frame rate is a bit choppy since I'm connected through Remote Desktop, but I did feel the difference. smoothScrolling.mov |
@luabud when it's off, scrolling should "snap" immediately to the row, otherwise it would animate the scroll over 125ms. If you're using a scroll pad instead of a mouse it's much harder to notice as scroll pads have a feature called "ballistic scrolling" which does something similar already |
@Tyriar ahh that makes sense, thank you! I was indeed using a scroll pad. I tested with the mouse now and was able to notice the difference. |
Refs: #125950
Complexity: 1
Authors: @meganrogge @Tyriar
Create Issue
The terminal now features smooth scrolling like in the editor. To test, enable
"terminal.integrated.smoothScrolling": true
and see if it acts like the editor.Note that it's expected that all rows in the terminal are still "snapped" to the grid.
The text was updated successfully, but these errors were encountered: