Popup blocked opening the codespace

[bpasero]

Testing #161875

Source: insiders.vscode.dev
Target: GH Codespace

The CS was not opened due to popup blocking:

[joyceerhl]

@bpasero The created codespace should have opened in a new tab, which browser is this, and did you configure a popup blocking preference before? Does this happen for all external links opened from vscode.dev?

[bpasero]

No this happened because from my user interaction to opening the window, a lot of time passed. Next time I did this, the window opened. I believe browser vendors have different thresholds where they allow a window from opening when it is close to user action. I know Safari is worst here which even made us implement a fallback:

vscode/src/vs/workbench/browser/window.ts

Lines 160 to 194 in ea5b244

	// HTTP(s): open in new window and deal with potential popup blockers
	if (matchesScheme(href, Schemas.http) || matchesScheme(href, Schemas.https)) {
	if (isSafari) {
	const opened = windowOpenWithSuccess(href, !isAllowedOpener);
	if (!opened) {
	const showResult = await this.dialogService.show(
	Severity.Warning,
	localize('unableToOpenExternal', "The browser interrupted the opening of a new tab or window. Press 'Open' to open it anyway."),
	[
	localize('open', "Open"),
	localize('learnMore', "Learn More"),
	localize('cancel', "Cancel")
	],
	{
	cancelId: 2,
	detail: href
	}
	);
	if (showResult.choice === 0) {
	isAllowedOpener
	? windowOpenPopup(href)
	: windowOpenNoOpener(href);
	}
	if (showResult.choice === 1) {
	await this.openerService.open(URI.parse('https://aka.ms/allow-vscode-popup'));
	}
	}
	} else {
	isAllowedOpener
	? windowOpenPopup(href)
	: windowOpenNoOpener(href);
	}
	}

[joyceerhl]

@bpasero should we then always have this fallback logic even when not on Safari?

[bpasero]

Yeah why not, we have to validate that our logic works in other browsers 👍