Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No progress when storing a large edit session #164902

Closed
joyceerhl opened this issue Oct 28, 2022 · 0 comments
Closed

No progress when storing a large edit session #164902

joyceerhl opened this issue Oct 28, 2022 · 0 comments
Assignees
@joyceerhl
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Milestone
October 2022

Comments

@joyceerhl
Copy link
Collaborator

9ad0693 addressed a race condition which caused edit sessions to fail to store if using Continue On to a target that reloads the current window. As a result, if you have a relatively large edit session, now there are potentially 1-2 seconds where the user waits with no progress being shown, before the picker with Continue On options shows up.
@joyceerhl joyceerhl added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Oct 28, 2022
@joyceerhl joyceerhl added this to the October 2022 milestone Oct 28, 2022
@joyceerhl joyceerhl self-assigned this Oct 28, 2022
This was referenced Oct 28, 2022
Merged
Merged
@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Nov 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joyceerhl joyceerhl

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Milestone
October 2022
Development

No branches or pull requests
2 participants
@TylerLeonhardt @joyceerhl