Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Plan: Result Preview for Quick Search #203078

Closed
3 tasks done
andreamah opened this issue Jan 22, 2024 · 0 comments
Closed
3 tasks done

Test Plan: Result Preview for Quick Search #203078

andreamah opened this issue Jan 22, 2024 · 0 comments

Comments

@andreamah
Copy link
Contributor

andreamah commented Jan 22, 2024

Refs #191259

Complexity: 1

Create Issue


Background:

'Quick Search' is a feature that I recently implemented to get a quick glimpse of text results. To use it, you can type % in the quick open or run Search: Quick Search. It is also an option in the ? menu.

This is just another way to view workspace text search results. Later, we want to try integrating 'smart' copilot results into this, but for now, it just has workspace results.

Testing

This iteration, I implemented previewing on active pick for Quick Search (like we have for symbol search). When you have an item highlighted in the list, a preview editor should show the result in-editor.

2024-01-12.10-11-40.mp4

Also, if you press escape on the picker, you should be taken back to the editor that you were originally on (unless you were originally on a preview editor).

Current Limitations

  • This editor navigation is included in the history, meaning that back/forward will reflect these changes.
  • If you don't have preview editors enabled (workbench.editor.enablePreview), then opened windows will accumulate as you open them.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants