Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find in files reports only first 10,000 findings in each file #30017

Closed
lijh8 opened this issue Jul 2, 2017 · 4 comments
Closed

Find in files reports only first 10,000 findings in each file #30017

lijh8 opened this issue Jul 2, 2017 · 4 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@lijh8
Copy link

lijh8 commented Jul 2, 2017

Do you use your own editor when you are developing your editor?

  1. Please put the search panel at the bottom and
  2. make the results cope-able like Visual Studio (without the code) if possible

5

@vscodebot vscodebot bot added the workbench label Jul 2, 2017
@bpasero bpasero assigned alexdima and unassigned bpasero Jul 2, 2017
@bpasero bpasero added editor and removed workbench labels Jul 2, 2017
@alexdima alexdima assigned roblourens and unassigned alexdima Jul 3, 2017
@roblourens
Copy link
Member

  1. make the results cope-able like Visual Studio (without the code) if possible

Not sure what you mean by cope-able

@roblourens roblourens added the info-needed Issue requires more information from poster label Jul 7, 2017
@vscodebot vscodebot bot closed this as completed Jul 14, 2017
@vscodebot
Copy link

vscodebot bot commented Jul 14, 2017

This issue has been closed automatically because it needs more information and has not had recent activity. Please refer to our guidelines for filing issues. Thank you for your contributions.

@lijh8
Copy link
Author

lijh8 commented Jul 17, 2017

"copyable" -- there was a typo in the bug report.

cant believe that the bug report was closed without the bug being fixed.

are all these count problems (1. ctrl-shift-f, 2. ctrl-f, 3. selection highlight) some kind of limitation in your editor product? check out this too: #29965

you can compare your editor to sublimetext, souce insight, vim.

@roblourens
Copy link
Member

I see, thanks. Copying/exporting the search results is covered in #17920

The result limit is present because we tend to get slow when dealing with more results than that, and because our UI doesn't let you interact with that many results efficiently anyway.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

4 participants