Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jerkyl sass support #79406

Closed
Tyriar opened this issue Aug 18, 2019 · 5 comments
Closed

Support Jerkyl sass support #79406

Tyriar opened this issue Aug 18, 2019 · 5 comments
Assignees
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling *extension-candidate Issue identified as good extension implementation feature-request Request for new features or functionality
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 18, 2019

Jekyll's Sass integration is described in full here: https://jekyllrb.com/docs/assets/

Basically, any <file>.scss file is compiled to <file>.css if it contains frontmatter at the top:

---
---

body {
  background-color: red;
}

image

Additionally you can import from _sass/_<file> which don't need any special frontmatter to work.


You can use files.exclude to ignore it, but that hides the file from the user when it shouldn't be:

{
    "files.exclude": {
        "css/style.scss": true
    }
}

#47354 is asking for a way to easily hide errors, I think what I'd like is that plus the setting as described in #52011 to ignore files from problems only.

I don't think it's possible to disable this using the scss.lint.* settings

@Tyriar Tyriar added the css-less-scss Issues and items concerning CSS,Less,SCSS styling label Aug 18, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Aug 18, 2019

For a ./css/main.scss (this could be anywhere) with content:

@import "something"

./_sass/_something.scss is a valid import

@octref
Copy link
Contributor

octref commented Aug 18, 2019

I agree with jekyll/jekyll#3408 (comment)

Supporting arbitrary syntax extensions that's not in the language standard doesn't seem productive to me. It's a Jekyll problem for not going with standard scss.

@Tyriar
Copy link
Member Author

Tyriar commented Aug 19, 2019

@octref I agree, but I also think I should be able to ignore problems in certain files since these can happen for several reasons. While the Jekyll syntax isn't the best, it's seems pretty nice not to worry about setting up sass compilation at all.

@sandy081 sandy081 removed their assignment Aug 22, 2019
@octref octref added the feature-request Request for new features or functionality label Oct 22, 2019
@octref octref added this to the Backlog milestone Oct 22, 2019
@octref octref assigned aeschli and unassigned octref May 1, 2020
@aeschli aeschli changed the title Jekyll's built in Sass support results in a permanent problem diagnostic Support Jerkyl sass support May 5, 2020
@aeschli aeschli added the *extension-candidate Issue identified as good extension implementation label May 5, 2020
@aeschli
Copy link
Contributor

aeschli commented May 5, 2020

I think that has to come from an extension.

  • extension defines a new language jerkyl-scss
  • extension implements a new language server based on our css language service.

See https://code.visualstudio.com/api/language-extensions/embedded-languages

@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling *extension-candidate Issue identified as good extension implementation feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants
@Tyriar @octref @aeschli @sandy081 and others