Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Editor peek say "Definitions ()" #91478

Closed
gregvanl opened this issue Feb 25, 2020 · 1 comment
Closed

Search Editor peek say "Definitions ()" #91478

gregvanl opened this issue Feb 25, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search-editor wont-fix
Milestone

Comments

@gregvanl
Copy link

  • VSCode Version: 1.43 Insiders
  • OS Version: Windows 10

Found while testing #91331

Steps to Reproduce:

  1. Open the vscode-docs repo and create an empty Search Editor
  2. Search for "VSCode" and set Match Case and Match Whole Word
  3. Double-click on a file path to open the Peek view.

Title bar says "Definitions ()" with the count. I would have expected the text to say "Matches ()"

image

@JacksonKearl JacksonKearl added the bug Issue identified by VS Code Team member as probable bug label Feb 27, 2020
@JacksonKearl JacksonKearl added this to the Backlog milestone Feb 27, 2020
@JacksonKearl
Copy link
Contributor

Currently using all of the go-to-definition infrastructure for things like peek, open to side, keybinds, etc, I don't think we can change this without reimplementing all of that specific to the editor so going to close this out.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search-editor wont-fix
Projects
None yet
Development

No branches or pull requests

2 participants