Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new location hash scheme #353

Open
slr opened this issue Mar 30, 2016 · 6 comments
Open

new location hash scheme #353

slr opened this issue Mar 30, 2016 · 6 comments

Comments

@slr
Copy link
Collaborator

slr commented Mar 30, 2016

I want to change current one as part of #338

first, no base name for index page:
/home.html -> /

then following changes by example of @RealVegOs's alias:
/#profile?user=vegos -> /#/@vegos
/#mentions?user=vegos -> /#/@vegos/mentions
/#followers?user=vegos -> /#/@vegos/followers
/#following?user=vegos -> /#/@vegos/following
/#conversation?post=vegos:post14080 -> /#/@vegos/14080

hashtags:
/#hashtag?hashtag=letsfixeverythin -> /#/tag/letsfixeverythin

login, network stats/config, options:
/login.html -> /#/login
/network.html -> /#/network
/options.html -> /#/options

etc.

are you OK with that?

@miguelfreitas
Copy link
Owner

No objections!

thinking aloud: do we need the "/" in front of everything? I remember an old issue where the guy wanted to host twister-html into a subdirectory. Would it cause problems?

@slr
Copy link
Collaborator Author

slr commented Mar 30, 2016

do we need the "/" in front of everything?

there's need to read address:port/ instead of front /. but I believe you ask about the first slash after anchor tag. I don't know if we need this. it's a nice visual delimiter for me.

I remember an old issue where the guy wanted to host twister-html into a subdirectory. Would it cause problems?

according to RFC3986:

The path is terminated by the first question mark ("?") or number sign ("#") character, or by the end of the URI.

so all the chars after # is "fragment" (or location hash in browsers terminology). we may find examples of fragments which are similar to ours in section 5.4.2. Abnormal Examples and read about them there:

all URI parsers should be capable of resolving them consistently.

@homlett
Copy link

homlett commented Mar 30, 2016

I'm the guy. That will be fine I think. I'll give you a feedback if I encounter problems. And I'm agree that would be great to improve the location hash scheme.

@miguelfreitas
Copy link
Owner

thanks @homlett for paying attention :-)

@slr
Copy link
Collaborator Author

slr commented Feb 2, 2017

/login.html -> /#/login

b164691

@slr
Copy link
Collaborator Author

slr commented Feb 2, 2019

/profile-edit.html -> /#/account

cecd428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants