-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove namespace Core, Debugger, Controls #58
Comments
It took me 40+ commits to move from libRocket to RmlUi, I'd rather prefer it to remain stable for a while :P |
Yeah, you have a point there. Okay, I'm putting this off for some time. Maybe for RmlUi 4.0 ;) |
I do agree with @viciious , it's not easy to keep up with the huge amount of commits, but at the same time, I think the Controls namespace is useless. When one wants to use RmlUi they want to use the whole library, controls included. There is no need to do multiple Initialisations (I almost forgot I had to recently). The only module that doesn't require to be initialised is the Debugger, so probably the only namespace I suggest to leave unchanged is that one. |
Do we even need the separate Controls lib at all? It has always bugged me that I need to compile two libs to get the most basic things working. |
Yeah, an unique library would be optimal, I always compile them together when I setup my Visual Studio Projects. The only problem is that there are multiple .cpp files with the same name, that's probably the reason why they got separated in the first place. |
Yeah, integrating the Controls library into Core is very tempting, I don't see many people having the need for the library without it. On the other hand, it helps a bit with navigating the code, and also forcing a well defined separation of principles (ie. Core not depending on Control elements). I think removing the Core and Controls namespaces would go a long way in making it easier and more comfortable to use the library. |
See e9844e3. I decided to merge the Controls library. Let me know if you have any comments before I merge into master. Se the detailed changes here: https://github.com/mikke89/RmlUi/blob/merge_controls/changelog.md#restructuring-rmlui. |
Usage of RmlUi would be a lot simpler if we removed the sub-namespaces. I don't feel like they are really necessary.
Thus,
would become
We may need to keep the namespaces for some functions, so this stays the same:
or, maybe remove it for core?
I haven't tried it to see if there are any name conflicts, but worst case is we need to do some renaming.
Thoughts?
The text was updated successfully, but these errors were encountered: