Merge pull request #1046 from orien/ruby3.2

CI: add Ruby 3.2 to the test matrix

Author: unixmonkey

.github/workflows/ci.yml

@@ -28,29 +28,29 @@ jobs:
           - gemfile: "6.1"
             ruby-version: 2.7
           - gemfile: "6.1"
-            ruby-version: 3.0
+            ruby-version: '3.0'
           - gemfile: "7.0"
             ruby-version: 3.1
+          - gemfile: "7.0"
+            ruby-version: 3.2
 
     env:
-      BUNDLE_GEMFILE: /home/runner/work/wicked_pdf/wicked_pdf/gemfiles/${{ matrix.gemfile }}.gemfile
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
       WKHTMLTOPDF_BIN: /usr/bin/wkhtmltopdf
 
     steps:
-      - uses: actions/checkout@v2
-
-      - name: Install Ruby ${{ matrix.ruby-version }}
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: ${{ matrix.ruby-version }}
+      - uses: actions/checkout@v3
 
       - name: Install OS dependencies
         run: |
           sudo apt-get update -y -qq
           sudo apt-get install -y wkhtmltopdf
 
-      - name: Install gem dependencies
-        run: bundle install
+      - name: Install Ruby ${{ matrix.ruby-version }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
 
       - name: Run tests with Ruby ${{ matrix.ruby-version }} and Rails ${{ matrix.gemfile }}
         run: bundle exec rake

.rubocop.yml

@@ -2,10 +2,12 @@ inherit_from: .rubocop_todo.yml
 
 AllCops:
   NewCops: disable
+  SuggestExtensions: false
   TargetRubyVersion: 2.6
   Exclude:
     - 'gemfiles/bin/*'
     - 'test/dummy/**/*'
+    - 'vendor/**/*'
 
 Metrics/PerceivedComplexity:
   Enabled: false

.rubocop_todo.yml

@@ -1,45 +1,39 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-10-09 14:16:04 +0200 using RuboCop version 0.68.1.
+# on 2023-01-24 11:24:49 UTC using RuboCop version 1.44.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 11
-Metrics/AbcSize:
-  Max: 45
-
 # Offense count: 2
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 250
+  Max: 203
 
 # Offense count: 7
+# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods.
 Metrics/CyclomaticComplexity:
   Max: 13
 
 # Offense count: 17
-# Configuration parameters: CountComments, ExcludedMethods.
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods.
 Metrics/MethodLength:
-  Max: 40
+  Max: 34
 
-# Offense count: 2
-# Configuration parameters: CountComments.
+# Offense count: 1
+# Configuration parameters: CountComments, CountAsOne.
 Metrics/ModuleLength:
-  Max: 147
+  Max: 104
 
-# Offense count: 6
-Metrics/PerceivedComplexity:
-  Max: 13
-
-# Offense count: 2
+# Offense count: 1
 Naming/AccessorMethodName:
   Exclude:
     - 'lib/wicked_pdf/middleware.rb'
-    - 'lib/wicked_pdf/pdf_helper.rb'
 
 # Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowOnConstant, AllowOnSelfClass.
 Style/CaseEquality:
   Exclude:
     - 'lib/wicked_pdf/wicked_pdf_helper.rb'
@@ -49,66 +43,63 @@ Style/ClassVars:
   Exclude:
     - 'lib/wicked_pdf.rb'
 
-# Offense count: 10
+# Offense count: 13
+# Configuration parameters: AllowedConstants.
 Style/Documentation:
   Exclude:
     - 'spec/**/*'
     - 'test/**/*'
     - 'generators/wicked_pdf/wicked_pdf_generator.rb'
     - 'lib/wicked_pdf.rb'
+    - 'lib/wicked_pdf/binary.rb'
     - 'lib/wicked_pdf/middleware.rb'
+    - 'lib/wicked_pdf/option_parser.rb'
     - 'lib/wicked_pdf/pdf_helper.rb'
     - 'lib/wicked_pdf/progress.rb'
     - 'lib/wicked_pdf/railtie.rb'
-    - 'lib/wicked_pdf/binary.rb'
-    - 'lib/wicked_pdf/option_parser.rb'
     - 'lib/wicked_pdf/tempfile.rb'
     - 'lib/wicked_pdf/wicked_pdf_helper.rb'
     - 'lib/wicked_pdf/wicked_pdf_helper/assets.rb'
 
 # Offense count: 2
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 Style/ExpandPathArguments:
   Exclude:
     - 'test/test_helper.rb'
     - 'wicked_pdf.gemspec'
 
-# Offense count: 8
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
 # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
+# SupportedShorthandSyntax: always, never, either, consistent
 Style/HashSyntax:
   Exclude:
-    - 'gemfiles/4.0.gemfile'
-    - 'gemfiles/4.1.gemfile'
-    - 'gemfiles/4.2.gemfile'
     - 'gemfiles/5.0.gemfile'
     - 'gemfiles/5.1.gemfile'
     - 'gemfiles/5.2.gemfile'
     - 'gemfiles/6.0.gemfile'
-    - 'gemfiles/rails_edge.gemfile'
 
 # Offense count: 2
-# Cop supports --auto-correct.
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: literals, strict
 Style/MutableConstant:
   Exclude:
     - 'lib/wicked_pdf/wicked_pdf_helper/assets.rb'
 
-# Offense count: 6
-# Cop supports --auto-correct.
+# Offense count: 5
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
 # SupportedStyles: slashes, percent_r, mixed
 Style/RegexpLiteral:
   Exclude:
     - 'lib/wicked_pdf/middleware.rb'
     - 'lib/wicked_pdf/wicked_pdf_helper/assets.rb'
-    - 'test/unit/wicked_pdf_test.rb'
 
-# Offense count: 111
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# Offense count: 18
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns.
 # URISchemes: http, https
-Metrics/LineLength:
+Layout/LineLength:
   Max: 563

gemfiles/6.1.gemfile

@@ -7,6 +7,5 @@ gem 'webpacker'
 gem 'rdoc'
 gem 'sprockets', '~>3.0'
 gem 'sqlite3', '~> 1.4'
-gem 'rubocop', '1.11.0'
 
 gemspec :path => '../'

gemfiles/7.0.gemfile

@@ -7,6 +7,5 @@ gem 'sprockets-rails'
 gem 'rdoc'
 gem 'sprockets', '~>3.0'
 gem 'sqlite3', '~> 1.4'
-gem 'rubocop', '1.11.0'
 
 gemspec :path => '../'