Skip to content

Commit aa6cfd6

Browse files
balamuruganaharshavardhana
authored andcommitted
fix: remove wrong policy comparison in functional tests (#974)
1 parent 3007bfa commit aa6cfd6

File tree

1 file changed

+3
-17
lines changed

1 file changed

+3
-17
lines changed

functional_tests.go

+3-17
Original file line numberDiff line numberDiff line change
@@ -3491,15 +3491,11 @@ func testFunctional() {
34913491
args = map[string]interface{}{
34923492
"bucketName": bucketName,
34933493
}
3494-
readOnlyPolicyRet, err := c.GetBucketPolicy(bucketName)
3494+
_, err = c.GetBucketPolicy(bucketName)
34953495
if err != nil {
34963496
logError(testName, function, args, startTime, "", "GetBucketPolicy failed", err)
34973497
return
34983498
}
3499-
if readOnlyPolicyRet == "" {
3500-
logError(testName, function, args, startTime, "", "policy should be set", err)
3501-
return
3502-
}
35033499

35043500
// Make the bucket 'public writeonly'.
35053501
function = "SetBucketPolicy(bucketName, writeOnlyPolicy)"
@@ -3523,17 +3519,12 @@ func testFunctional() {
35233519
"bucketName": bucketName,
35243520
}
35253521

3526-
writeOnlyPolicyRet, err := c.GetBucketPolicy(bucketName)
3522+
_, err = c.GetBucketPolicy(bucketName)
35273523
if err != nil {
35283524
logError(testName, function, args, startTime, "", "GetBucketPolicy failed", err)
35293525
return
35303526
}
35313527

3532-
if writeOnlyPolicyRet == "" {
3533-
logError(testName, function, args, startTime, "", "policy should be set", err)
3534-
return
3535-
}
3536-
35373528
// Make the bucket 'public read/write'.
35383529
function = "SetBucketPolicy(bucketName, readWritePolicy)"
35393530
functionAll += ", " + function
@@ -3556,17 +3547,12 @@ func testFunctional() {
35563547
args = map[string]interface{}{
35573548
"bucketName": bucketName,
35583549
}
3559-
readWritePolicyRet, err := c.GetBucketPolicy(bucketName)
3550+
_, err = c.GetBucketPolicy(bucketName)
35603551
if err != nil {
35613552
logError(testName, function, args, startTime, "", "GetBucketPolicy failed", err)
35623553
return
35633554
}
35643555

3565-
if readWritePolicyRet == "" {
3566-
logError(testName, function, args, startTime, "", "policy should be set", err)
3567-
return
3568-
}
3569-
35703556
// List all buckets.
35713557
function = "ListBuckets()"
35723558
functionAll += ", " + function

0 commit comments

Comments
 (0)