Fix some always true/false errors in codebase

Testing out latest TS nightly that can identify when an expression is always true/false. This caught a few likely coding mistakes in our codebase

Unsure about the intent in some of these cases but I've tried my best to understand them. Pinging relevant code owners for the confusing cases

Author: mjbvz

extensions/github-authentication/src/githubServer.ts

@@ -197,7 +197,7 @@ export class GitHubServer implements IGitHubServer {
 				throw new Error(`${result.status} ${result.statusText}`);
 			}
 		} catch (e) {
-			this._logger.warn('Failed to delete token from server.' + e.message ?? e);
+			this._logger.warn('Failed to delete token from server.' + (e.message ?? e));
 		}
 	}
 

package.json

@@ -209,7 +209,7 @@
     "ts-loader": "^9.4.2",
     "ts-node": "^10.9.1",
     "tsec": "0.2.7",
-    "typescript": "^5.6.0-dev.20240715",
+    "typescript": "^5.6.0-dev.20240723",
     "util": "^0.12.4",
     "vscode-nls-dev": "^3.3.1",
     "webpack": "^5.91.0",

src/vs/editor/standalone/test/browser/monarch.test.ts

@@ -233,7 +233,7 @@ suite('Monarch', () => {
 			uselessReplaceKey2: '@uselessReplaceKey3',
 			uselessReplaceKey3: '@uselessReplaceKey4',
 			uselessReplaceKey4: '@uselessReplaceKey5',
-			uselessReplaceKey5: '@ham' || '',
+			uselessReplaceKey5: '@ham',
 			tokenizer: {
 				root: [
 					{

src/vs/platform/files/test/browser/indexedDBFileService.integrationTest.ts

@@ -189,7 +189,7 @@ flakySuite('IndexedDBFileSystemProvider', function () {
 				assert.strictEqual(value.mtime, undefined);
 				assert.strictEqual(value.ctime, undefined);
 			} else {
-				assert.ok(!'Unexpected value ' + basename(value.resource));
+				assert.fail('Unexpected value ' + basename(value.resource));
 			}
 		});
 	});

src/vs/platform/files/test/node/diskFileService.integrationTest.ts

@@ -273,7 +273,7 @@ flakySuite('Disk File Service', function () {
 				assert.strictEqual(value.mtime, undefined);
 				assert.strictEqual(value.ctime, undefined);
 			} else {
-				assert.ok(!'Unexpected value ' + basename(value.resource.fsPath));
+				assert.fail('Unexpected value ' + basename(value.resource.fsPath));
 			}
 		});
 	});
@@ -317,7 +317,7 @@ flakySuite('Disk File Service', function () {
 				assert.ok(value.mtime > 0);
 				assert.ok(value.ctime > 0);
 			} else {
-				assert.ok(!'Unexpected value ' + basename(value.resource.fsPath));
+				assert.fail('Unexpected value ' + basename(value.resource.fsPath));
 			}
 		});
 	});

src/vs/workbench/contrib/comments/browser/simpleCommentEditor.ts

@@ -145,7 +145,7 @@ export class SimpleCommentEditor extends CodeEditorWidget {
 export function calculateEditorHeight(parentEditor: LayoutableEditor, editor: ICodeEditor, currentHeight: number): number {
 	const layoutInfo = editor.getLayoutInfo();
 	const lineHeight = editor.getOption(EditorOption.lineHeight);
-	const contentHeight = (editor._getViewModel()?.getLineCount()! * lineHeight) ?? editor.getContentHeight(); // Can't just call getContentHeight() because it returns an incorrect, large, value when the editor is first created.
+	const contentHeight = (editor._getViewModel()?.getLineCount()! * lineHeight); // Can't just call getContentHeight() because it returns an incorrect, large, value when the editor is first created.
 	if ((contentHeight > layoutInfo.height) ||
 		(contentHeight < layoutInfo.height && currentHeight > MIN_EDITOR_HEIGHT)) {
 		const linesToAdd = Math.ceil((contentHeight - layoutInfo.height) / lineHeight);

src/vs/workbench/contrib/customEditor/browser/customEditors.ts

@@ -132,7 +132,7 @@ export class CustomEditorService extends Disposable implements ICustomEditorServ
 						priority: contributedEditor.priority,
 					},
 					{
-						singlePerResource: () => !this.getCustomEditorCapabilities(contributedEditor.id)?.supportsMultipleEditorsPerDocument ?? true
+						singlePerResource: () => !(this.getCustomEditorCapabilities(contributedEditor.id)?.supportsMultipleEditorsPerDocument ?? false)
 					},
 					{
 						createEditorInput: ({ resource }, group) => {

src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts

@@ -615,7 +615,7 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
 		// We need to first wait for extensions to be registered because we might read
 		// the `TaskDefinitionRegistry` in case `type` is `undefined`
 		await this._extensionService.whenInstalledExtensionsRegistered();
-		this._log('Activating task providers ' + type ?? 'all');
+		this._log('Activating task providers ' + (type ?? 'all'));
 		await raceTimeout(
 			Promise.all(this._getActivationEvents(type).map(activationEvent => this._extensionService.activateByEvent(activationEvent))),
 			5000,

src/vs/workbench/contrib/terminal/browser/terminalInstance.ts

@@ -1633,7 +1633,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
 			id: TerminalStatus.ShellIntegrationAttentionNeeded,
 			severity: Severity.Warning,
 			icon: Codicon.warning,
-			tooltip: (`${exitMessage} ` ?? '') + nls.localize('launchFailed.exitCodeOnlyShellIntegration', 'Disabling shell integration in user settings might help.'),
+			tooltip: `${exitMessage} ` + nls.localize('launchFailed.exitCodeOnlyShellIntegration', 'Disabling shell integration in user settings might help.'),
 			hoverActions: [{
 				commandId: TerminalCommandId.ShellIntegrationLearnMore,
 				label: nls.localize('shellIntegration.learnMore', "Learn more about shell integration"),

src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatController.ts

@@ -274,7 +274,7 @@ export class TerminalChatController extends Disposable implements ITerminalContr
 	}
 
 	hasFocus(): boolean {
-		return !!this._chatWidget?.rawValue?.hasFocus() ?? false;
+		return this._chatWidget?.rawValue?.hasFocus() ?? false;
 	}
 
 	populateHistory(up: boolean) {

src/vs/workbench/contrib/testing/browser/testingExplorerView.ts

@@ -136,7 +136,7 @@ export class TestingExplorerView extends ViewPane {
 	}
 
 	public override shouldShowWelcome() {
-		return this.viewModel?.welcomeExperience === WelcomeExperience.ForWorkspace ?? true;
+		return this.viewModel ? this.viewModel.welcomeExperience === WelcomeExperience.ForWorkspace : true;
 	}
 
 	public override focus() {

src/vs/workbench/contrib/timeline/browser/timelinePane.ts

@@ -67,7 +67,7 @@ function isLoadMoreCommand(item: TreeElement | undefined): item is LoadMoreComma
 }
 
 function isTimelineItem(item: TreeElement | undefined): item is TimelineItem {
-	return !item?.handle.startsWith('vscode-command:') ?? false;
+	return !!item && !item.handle.startsWith('vscode-command:');
 }
 
 function updateRelativeTime(item: TimelineItem, lastRelativeTime: string | undefined): string | undefined {

yarn.lock

@@ -10321,10 +10321,10 @@ typescript@^4.7.4:
   resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.8.4.tgz#c464abca159669597be5f96b8943500b238e60e6"
   integrity sha512-QCh+85mCy+h0IGff8r5XWzOVSbBO+KfeYrMQh7NJ58QujwcE22u+NUSmUxqF+un70P9GXKxa2HCNiTTMJknyjQ==
 
-typescript@^5.6.0-dev.20240715:
-  version "5.6.0-dev.20240715"
-  resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.6.0-dev.20240715.tgz#18b9e994f99916b90917943d5de8e78f781d1d70"
-  integrity sha512-CLF8WFoqLgHgxQqjklkEOw3gT99Y2YNU4+TfkJurX5bfejAUYpb2jBjiYOn5Rq9HCew6ceZlRaG7Q++6/fBvVA==
+typescript@^5.6.0-dev.20240723:
+  version "5.6.0-dev.20240723"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.6.0-dev.20240723.tgz#de2cbd7a67f356af4122359a44efb6a6805dd823"
+  integrity sha512-IciIh6EUuMxUQ9OvnmBtrkJwuVD9zWhl9smsA+5yYz9Zpodi5qs4qhp4KldiUj86dRGREtT3+10PpUX7RMm02Q==
 
 typical@^4.0.0:
   version "4.0.0"