add missing Inc() in use of metrics with labels

Author: mjl-

dns.go

@@ -510,7 +510,7 @@ func process(log *slog.Logger, buf []byte, udp bool, remaddr net.Addr) (respmsg
 		}
 	}()
 
-	metricDNSOpcode.WithLabelValues(dns.OpcodeToString[inmsg.Opcode])
+	metricDNSOpcode.WithLabelValues(dns.OpcodeToString[inmsg.Opcode]).Inc()
 	if inmsg.Opcode != dns.OpcodeQuery {
 		return response(inmsg, dns.RcodeNotImplemented), false, false, fmt.Errorf("request opcode %d %q not implemented", inmsg.Opcode, dns.OpcodeToString[inmsg.Opcode])
 	}
@@ -528,7 +528,7 @@ func process(log *slog.Logger, buf []byte, udp bool, remaddr net.Addr) (respmsg
 		if dnssecok {
 			dnssec = "yes"
 		}
-		metricDNSQuery.WithLabelValues(dns.TypeToString[q.Qtype], dnssec, dns.RcodeToString[respmsg.Rcode])
+		metricDNSQuery.WithLabelValues(dns.TypeToString[q.Qtype], dnssec, dns.RcodeToString[respmsg.Rcode]).Inc()
 	}()
 
 	// Special queries that are actually more like opcodes. ANY is handled later.

moxapi.go

@@ -237,10 +237,10 @@ func webhookIncoming(w http.ResponseWriter, r *http.Request) {
 			Flags: []string{config.KeywordPrefix + "signup", `\seen`, `\answered`},
 		}
 		if _, err := webapiClient.MessageFlagsAdd(ctx, flagsReq); err != nil {
-			metricWebAPIResults.WithLabelValues("MessageFlagsAdd", webapiErrorCode(err))
+			metricWebAPIResults.WithLabelValues("MessageFlagsAdd", webapiErrorCode(err)).Inc()
 			return fmt.Errorf("setting seen and answered message flags: %v", err)
 		}
-		metricWebAPIResults.WithLabelValues("MessageFlagsAdd", "ok")
+		metricWebAPIResults.WithLabelValues("MessageFlagsAdd", "ok").Inc()
 
 		metricIncomingSignup.Inc()
 		return nil
@@ -300,7 +300,7 @@ func webapiSend(ctx context.Context, meta bool, user User, origMessageID string,
 		if rerr != nil {
 			result = webapiErrorCode(rerr)
 		}
-		metricWebAPIResults.WithLabelValues("Send", result)
+		metricWebAPIResults.WithLabelValues("Send", result).Inc()
 	}()
 	resp, err := webapiClient.Send(ctx, req)
 	if err != nil {