unconfuse "subscribed" boolean vs "unsubscribed", fixing the log message about subscription change claiming the opposite change of what happened

Author: mjl-

api.go

@@ -890,20 +890,22 @@ func (API) SubscribeSet(ctx context.Context, meta, subscribed bool) {
 		err := tx.Get(&u)
 		xcheckf(err, "get user")
 
+		unsub := !subscribed
+
 		var kind string
 		if meta {
 			kind = "service messages"
-			if u.MetaUnsubscribed == subscribed {
+			if u.MetaUnsubscribed == unsub {
 				xusererrorf("already set")
 			} else {
-				u.MetaUnsubscribed = subscribed
+				u.MetaUnsubscribed = unsub
 			}
 		} else {
 			kind = "module update messages"
-			if u.UpdatesUnsubscribed == subscribed {
+			if u.UpdatesUnsubscribed == unsub {
 				xusererrorf("already set")
 			} else {
-				u.UpdatesUnsubscribed = subscribed
+				u.UpdatesUnsubscribed = unsub
 			}
 		}
 

index.js

@@ -1238,13 +1238,13 @@ const overview = async () => {
 		const render = () => {
 			let elem = dom.div(dom.p('Change the kind of email messages you will receive:'), dom.table(dom.tr(dom.th('Kind'), dom.th('Status'), dom.th('Action')), dom.tr(dom.td('Service messages', attr.title('Like password reset and announcements.')), dom.td(overview.MetaUnsubscribed ? 'Unsubscribed' : 'Subscribed'), dom.clickbutton(overview.MetaUnsubscribed ? 'Resubscribe' : 'Unsubscribe', async function click(e) {
 				await check(e.target, async () => {
-					await client.SubscribeSet(true, !overview.MetaUnsubscribed);
+					await client.SubscribeSet(true, overview.MetaUnsubscribed);
 					overview.MetaUnsubscribed = !overview.MetaUnsubscribed;
 					elem.replaceWith(render());
 				});
 			})), dom.tr(dom.td('Module updates'), dom.td(overview.UpdatesUnsubscribed ? 'Unsubscribed' : 'Subscribed'), dom.clickbutton(overview.UpdatesUnsubscribed ? 'Resubscribe' : 'Unsubscribe', async function click(e) {
 				await check(e.target, async () => {
-					await client.SubscribeSet(false, !overview.UpdatesUnsubscribed);
+					await client.SubscribeSet(false, overview.UpdatesUnsubscribed);
 					overview.UpdatesUnsubscribed = !overview.UpdatesUnsubscribed;
 					elem.replaceWith(render());
 				});

index.ts

@@ -696,7 +696,7 @@ const overview = async () => {
 							dom.td(overview.MetaUnsubscribed ? 'Unsubscribed' : 'Subscribed'),
 							dom.clickbutton(overview.MetaUnsubscribed ? 'Resubscribe' : 'Unsubscribe', async function click(e: MouseEvent) {
 								await check(e.target! as HTMLButtonElement, async () => {
-									await client.SubscribeSet(true, !overview.MetaUnsubscribed)
+									await client.SubscribeSet(true, overview.MetaUnsubscribed)
 									overview.MetaUnsubscribed = !overview.MetaUnsubscribed
 									elem.replaceWith(render())
 								})
@@ -707,7 +707,7 @@ const overview = async () => {
 							dom.td(overview.UpdatesUnsubscribed ? 'Unsubscribed' : 'Subscribed'),
 							dom.clickbutton(overview.UpdatesUnsubscribed ? 'Resubscribe' : 'Unsubscribe', async function click(e: MouseEvent) {
 								await check(e.target! as HTMLButtonElement, async () => {
-									await client.SubscribeSet(false, !overview.UpdatesUnsubscribed)
+									await client.SubscribeSet(false, overview.UpdatesUnsubscribed)
 									overview.UpdatesUnsubscribed = !overview.UpdatesUnsubscribed
 									elem.replaceWith(render())
 								})