don't allow making subscriptions that match pseudoversions but not prerelease versions

they will never match

Author: mjl-

api.go

@@ -977,6 +977,9 @@ func (API) SubscriptionCreate(ctx context.Context, sub Subscription) Subscriptio
 	reqInfo := ctx.Value(requestInfoCtxKey).(requestInfo)
 
 	xcheckModule(sub.Module)
+	if sub.Pseudo && !sub.Prerelease {
+		xusererrorf("subscription for pseudoversions without prerelease versions will never match")
+	}
 
 	sub.ID = 0
 	sub.UserID = reqInfo.UserID
@@ -1056,6 +1059,9 @@ func (API) SubscriptionSave(ctx context.Context, sub Subscription) {
 	reqInfo := ctx.Value(requestInfoCtxKey).(requestInfo)
 
 	xcheckModule(sub.Module)
+	if sub.Pseudo && !sub.Prerelease {
+		xusererrorf("subscription for pseudoversions without prerelease versions will never match")
+	}
 
 	err := database.Write(ctx, func(tx *bstore.Tx) error {
 		exists, err := bstore.QueryTx[Subscription](tx).FilterNonzero(Subscription{ID: sub.ID, UserID: reqInfo.UserID}).Exists()

index.js

@@ -1051,7 +1051,11 @@ const subscriptionPopup = (sub, subscriptions, hookconfigs, render) => {
 		// User may input a URL, better fix it for them instead of making the user fix it.
 		module.value = module.value.replace(/^https?:\/\//, '');
 		module.value = module.value.replace(/\/*$/, '');
-	}), dom.div(dom._class('explain'), 'Enter a single module as you would use in a Go import statement.', dom.br(), 'Example: github.com/mjl-/gopherwatch, github.com/mjl- or golang.org.'))), dom.br(), dom.b('Notify about ...'), dom.label(belowModule = dom.input(attr.type('checkbox'), sub.BelowModule ? attr.checked('') : []), ' ', dom.span('Sub modules', attr.title('E.g. if subscribed to github.com/mjl-, whether to match github.com/mjl-/gopherwatch.'))), dom.label(olderVersions = dom.input(attr.type('checkbox'), sub.OlderVersions ? attr.checked('') : []), ' ', dom.span('Older versions than already seen', attr.title('Can happen when an old version (tag) is requested through the Go module proxy after a later tag, not uncommon after forking a repository and pushing all historic tags.'))), dom.label(prerelease = dom.input(attr.type('checkbox'), sub.Prerelease ? attr.checked('') : []), ' Prereleases such as v1.2.3-beta1'), dom.label(pseudo = dom.input(attr.type('checkbox'), sub.Pseudo ? attr.checked('') : []), ' Pseudo versions, such as v0.0.0-20240222094833-a1bd684a916b'), dom.br(), dom.label('Comment', 
+	}), dom.div(dom._class('explain'), 'Enter a single module as you would use in a Go import statement.', dom.br(), 'Example: github.com/mjl-/gopherwatch, github.com/mjl- or golang.org.'))), dom.br(), dom.b('Notify about ...'), dom.label(belowModule = dom.input(attr.type('checkbox'), sub.BelowModule ? attr.checked('') : []), ' ', dom.span('Sub modules', attr.title('E.g. if subscribed to github.com/mjl-, whether to match github.com/mjl-/gopherwatch.'))), dom.label(olderVersions = dom.input(attr.type('checkbox'), sub.OlderVersions ? attr.checked('') : []), ' ', dom.span('Older versions than already seen', attr.title('Can happen when an old version (tag) is requested through the Go module proxy after a later tag, not uncommon after forking a repository and pushing all historic tags.'))), dom.label(prerelease = dom.input(attr.type('checkbox'), sub.Prerelease ? attr.checked('') : []), ' Prereleases such as v1.2.3-beta1'), dom.label(pseudo = dom.input(attr.type('checkbox'), sub.Pseudo ? attr.checked('') : [], function change() {
+		if (pseudo.checked) {
+			prerelease.checked = true;
+		}
+	}), ' Pseudo versions, such as v0.0.0-20240222094833-a1bd684a916b'), attr.title('Pseudo versions are always prereleases. In order to match a pseudoversion, prerelease must also be checked.'), dom.br(), dom.label('Comment', 
 	// explicit String to prevent special scriptswitch handling
 	comment = dom.textarea(new String(sub.Comment))), dom.br(), dom.label('Delivery method', dom.div(webhookconfig = dom.select(dom.option('Email', attr.value('0')), hookconfigs.map(hc => dom.option('Webhook ' + hc.Name, attr.value('' + hc.ID), sub.HookConfigID === hc.ID ? attr.selected('') : []))))), dom.br(), dom.div(submitbtn = dom.submitbutton(sub.ID ? 'Save subscription' : 'Add subscription')))));
 	module.focus();

index.ts

@@ -296,7 +296,18 @@ const subscriptionPopup = (sub: api.Subscription, subscriptions: api.Subscriptio
 				dom.label(belowModule=dom.input(attr.type('checkbox'), sub.BelowModule ? attr.checked('') : []), ' ', dom.span('Sub modules', attr.title('E.g. if subscribed to github.com/mjl-, whether to match github.com/mjl-/gopherwatch.'))),
 				dom.label(olderVersions=dom.input(attr.type('checkbox'), sub.OlderVersions ? attr.checked('') : []), ' ', dom.span('Older versions than already seen', attr.title('Can happen when an old version (tag) is requested through the Go module proxy after a later tag, not uncommon after forking a repository and pushing all historic tags.'))),
 				dom.label(prerelease=dom.input(attr.type('checkbox'), sub.Prerelease ? attr.checked('') : []), ' Prereleases such as v1.2.3-beta1'),
-				dom.label(pseudo=dom.input(attr.type('checkbox'), sub.Pseudo ? attr.checked('') : []), ' Pseudo versions, such as v0.0.0-20240222094833-a1bd684a916b'),
+				dom.label(
+					pseudo=dom.input(
+						attr.type('checkbox'),
+						sub.Pseudo ? attr.checked('') : [],
+						function change() {
+							if (pseudo.checked) {
+								prerelease.checked = true
+							}
+						},
+					),
+					' Pseudo versions, such as v0.0.0-20240222094833-a1bd684a916b'),
+					attr.title('Pseudo versions are always prereleases. In order to match a pseudoversion, prerelease must also be checked.'),
 				dom.br(),
 				dom.label(
 					'Comment',