Skip to content

Commit acfa786

Browse files
akpm00broonie
authored andcommitted
support-resetting-warn_once-checkpatch-fixes
ERROR: code indent should use tabs where possible torvalds#124: FILE: kernel/panic.c:604: + clear_warn_once_set,$ WARNING: please, no spaces at the start of a line torvalds#124: FILE: kernel/panic.c:604: + clear_warn_once_set,$ ERROR: code indent should use tabs where possible torvalds#125: FILE: kernel/panic.c:605: +^I^I "%lld\n");$ WARNING: please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h) torvalds#135: FILE: kernel/panic.c:615: +__initcall(register_warn_debugfs); total: 2 errors, 2 warnings, 87 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile ./patches/support-resetting-warn_once.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Andi Kleen <ak@linux.intel.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent ed81046 commit acfa786

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

kernel/panic.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -601,8 +601,8 @@ static int clear_warn_once_set(void *data, u64 val)
601601

602602
DEFINE_SIMPLE_ATTRIBUTE(clear_warn_once_fops,
603603
NULL,
604-
clear_warn_once_set,
605-
"%lld\n");
604+
clear_warn_once_set,
605+
"%lld\n");
606606

607607
static __init int register_warn_debugfs(void)
608608
{
@@ -612,7 +612,7 @@ static __init int register_warn_debugfs(void)
612612
return 0;
613613
}
614614

615-
__initcall(register_warn_debugfs);
615+
device_initcall(register_warn_debugfs);
616616
#endif
617617

618618
#ifdef CONFIG_CC_STACKPROTECTOR

0 commit comments

Comments
 (0)