Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current Direction is ignored on 2 of 3 step functions #19

Closed
migoun opened this issue Dec 12, 2020 · 1 comment
Closed

Current Direction is ignored on 2 of 3 step functions #19

migoun opened this issue Dec 12, 2020 · 1 comment

Comments

@migoun
Copy link

migoun commented Dec 12, 2020

tweent.tcc

Only the first function:
inline const typename detail::tweentraits<T, Ts...>::valuesType & tween<T, Ts...>::step(int32_t dt, bool suppress) {
return step(static_cast(dt * currentDirection)/static_cast(total), suppress);
}

uses currentDirection. The other 2 step functions not

@mobius3
Copy link
Owner

mobius3 commented Dec 14, 2020

Good find. It is supposed to be in just one of them but it was on the wrong one. Steepping is chained and they all resolve in the float version of it (step(float, bool)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants