Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "Create Plan" button in the flight plan window #2277

Open
SirMortimer opened this issue Aug 11, 2019 · 5 comments
Open

Remove the "Create Plan" button in the flight plan window #2277

SirMortimer opened this issue Aug 11, 2019 · 5 comments
Labels

Comments

@SirMortimer
Copy link

When you click the "Flight Plan" button in the main window, you get the flight plan window with a single button in it that says "Create Plan" (not sure about the exact labels because i'm not currently looking at it). If there isn't a performance (or other) consideration barring it, I think that flight plan should be created as soon as the window opens to save that extra click.

Likewise, when you delete the last manœuvre and subsequently the flight plan, you should see a new (empty) plan instead of the "create" button.

@pleroy pleroy added the ui label Aug 11, 2019
@pleroy
Copy link
Member

pleroy commented Aug 14, 2019

I am a bit unsure what you have in mind for the deletion path.

At the moment when the last manœuvre gets deleted, you are left with an empty flight plan and a "Delete flight plan" button. It would seem odd to keep this button: its only effect would be to delete/recreate the flight plan, effectively resetting its parameters to the defaults.

It seems to me that the "Delete flight plan" button should go away entirely, and that the flight plan should be deleted when (1) there are no manœuvres left and (2) the "Flight plan" window gets closed. That would be more consistent, I think, with the path where opening the "Flight plan" window creates an empty plan.

Of course, when there are manœuvres left, closing the "Flight plan" window should not have any effect on the plan itself. Maybe this should be reflected in the text of the button shown in the main window ("Create flight plan" vs. "Show flight plan" or some such).

What do you think?

@SirMortimer
Copy link
Author

Resetting the plan whenever the last manœuvre is deleted might be inconvenient.

I have this bad habit that I seem unable to shake: when messing with flight plans, I sometimes get that orange message telling me that an integrator is unhappy with my lousy system performance and therefore I should increase steps or tolerance or CPU power or somesuch text (don't have the UI in front of me, so my recollection of that message is a bit foggy). Often I just start from scratch to reset everything to default settings, this to me this feels quicker and cleaner than fixing whatever parameters need to be fixed. It is usually at this point that I'll be angry at myself because now I have to dial up the flight plan prediction duration - again. I wouldn't want to force other users to experience that same anger.

Maybe just change the text on the delete button to "Reset Flight Plan" and do exactly that when it's pressed?

@pleroy
Copy link
Member

pleroy commented Aug 14, 2019

I am fine with a "Reset" button, but I think we need a "Delete" (or "Hide"?) button too. There are times (e.g., warping over long distances) where you don't need a flight plan. It would be very weird if a plan was created the first time you open the "Flight plan" window and you could never get rid of it afterwards.

@sthalik
Copy link

sthalik commented Feb 4, 2020

It would be very weird if a plan was created the first time you open the "Flight plan" window and you could never get rid of it afterwards.

Please consider disabling the planning if only a single maneuver node exists, and it has zero delta-v. Furthermore, zero delta-v interacts badly with RemoteTech, resulting in the vessel spinning indefinitely in arbitrary directions.

Technically adding an empty node can be useful for Kerbal Alarm Clock, but then again the user can add a throwaway fractional delta-v amount.

@SirMortimer
Copy link
Author

SirMortimer commented Feb 4, 2020

zero delta-v interacts badly with RemoteTech, resulting in the vessel spinning

If that is the case, this needs to be fixed by RemoteTech.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants