Skip to content

Commit 4d352e3

Browse files
committed
FIX-#7465: Properly implement Series.rename_axis
Signed-off-by: Jonathan Shi <jonathan.shi@snowflake.com>
1 parent c114e7b commit 4d352e3

File tree

2 files changed

+41
-0
lines changed

2 files changed

+41
-0
lines changed

modin/pandas/series.py

+24
Original file line numberDiff line numberDiff line change
@@ -1702,6 +1702,30 @@ def rename_axis(
17021702
mapper=mapper, index=index, axis=axis, copy=copy, inplace=inplace
17031703
)
17041704

1705+
def _set_axis_name(self, name, axis=0, inplace=False) -> Union[Series, None]:
1706+
"""
1707+
Alter the name of the axis.
1708+
1709+
Parameters
1710+
----------
1711+
name : str
1712+
Name for the Series.
1713+
axis : str or int, default: 0
1714+
The axis to set the label.
1715+
Only 0 is valid for Series.
1716+
inplace : bool, default: False
1717+
Whether to modify `self` directly or return a copy.
1718+
1719+
Returns
1720+
-------
1721+
Series or None
1722+
"""
1723+
axis = self._get_axis_number(axis) # raises ValueError if not 0
1724+
renamed = self if inplace else self.copy()
1725+
renamed.index = renamed.index.set_names(name)
1726+
if not inplace:
1727+
return renamed
1728+
17051729
def rename(
17061730
self,
17071731
index=None,

modin/tests/pandas/test_series.py

+17
Original file line numberDiff line numberDiff line change
@@ -5188,3 +5188,20 @@ def test_logical_binary_with_list(op):
51885188
result_md = getattr(series_md, op)(rhs)
51895189
result_pd = getattr(series_pd, op)(rhs)
51905190
df_equals(result_md, result_pd)
5191+
5192+
5193+
def test_rename_axis():
5194+
series_md, series_pd = create_test_series([0, 1, 2])
5195+
renamed_md = series_md.rename_axis("name")
5196+
renamed_pd = series_pd.rename_axis("name")
5197+
assert series_md.index.name is None
5198+
df_equals(renamed_md, renamed_pd)
5199+
series_md.rename_axis("name", inplace=True)
5200+
series_pd.rename_axis("name", inplace=True)
5201+
df_equals(series_md, series_pd)
5202+
# axis=1 is invalid for series
5203+
try:
5204+
series_pd.rename_axis("name", 1)
5205+
except Exception as err:
5206+
with pytest.raises(type(err)):
5207+
series_md.rename_axis("name", 1)

0 commit comments

Comments
 (0)