Fixes crucial bug when passing along responses which are arrays, which will be considered multiple arguments by fireEvent

Author: rauchg

Source/Core/Log.js

@@ -0,0 +1,25 @@
+/*
+Script: Log.js
+	Provides basic logging functionality for plugins to implement.
+
+	License:
+		MIT-style license.
+
+	Authors:
+		Guillermo Rauch
+*/
+
+var Log = new Class({
+	
+	log: function(){
+		Log.logger.call(this, arguments);
+	}
+	
+});
+
+Log.logged = [];
+
+Log.logger = function(){
+	if(window.console && console.log) console.log.apply(console, arguments);
+	else Log.logged.push(arguments);
+};

Source/Request/Request.JSONP.js

@@ -11,7 +11,7 @@ Script: Request.JSONP.js
 
 Request.JSONP = new Class({
 
-	Implements: [Chain, Events, Options],
+	Implements: [Chain, Events, Options, Log],
 
 	options: {/*
 		onRetry: $empty(intRetries),
@@ -24,7 +24,7 @@ Request.JSONP = new Class({
 		retries: 0,
 		timeout: 0,
 		link: 'ignore',
-		callBackKey: 'callback',
+		callbackKey: 'callback',
 		injectScript: document.head
 	},
 
@@ -57,7 +57,7 @@ Request.JSONP = new Class({
 
 		(function(){
 			var script = this.getScript(options);
-			MooTools.log('JSONP retrieving script with url: ' + script.src);
+			this.log('JSONP retrieving script with url: ' + script.src);
 			this.fireEvent('request', script);
 			this.running = true;
 
@@ -72,6 +72,7 @@ Request.JSONP = new Class({
 				} else if(script && this.options.timeout){
 					script.destroy();
 					this.cancel();
+					this.fireEvent('failure');
 				}					
 			}).delay(this.options.timeout, this);
 		}).delay(Browser.Engine.trident ? 50 : 0, this);
@@ -93,34 +94,28 @@ Request.JSONP = new Class({
 			case 'object': case 'hash': data = Hash.toQueryString(options.data);
 		}
 
-		var script = new Element('script', {
-			type: 'text/javascript',
-			src: options.url + 
-				 (options.url.test('\\?') ? '&' :'?') + 
-				 (options.callBackKey || this.options.callBackKey) + 
-				 "=Request.JSONP.requests["+ index +"]" + 
-				 (data ? '&' + data : '')
-		}).inject(this.options.injectScript);
+		var src = options.url + 
+			 (options.url.test('\\?') ? '&' :'?') + 
+			 (options.callbackKey || this.options.callbackKey) + 
+			 "=Request.JSONP.requests["+ index +"]" + 
+			 (data ? '&' + data : '');
+			
+		if (src.length > 2083) this.log('JSONP '+ src +' will fail in Internet Explorer, which enforces a 2083 bytes length limit on URIs');
+				
+		var script = new Element('script', {type: 'text/javascript', src: src});
 
 		Request.JSONP.requests.push(function(data){ this.success(data, script); }.bind(this));
 
-		return script;
+		return script.inject(this.options.injectScript);
 	},
 
 	success: function(data, script){
 		if (script) script.destroy();
 		this.running = false;
-		MooTools.log('JSONP successfully retrieved: ',  data);
-		this.fireEvent('complete', data).fireEvent('success', data).callChain();
+		this.log('JSONP successfully retrieved: ', data);
+		this.fireEvent('complete', [data]).fireEvent('success', [data]).callChain();
 	}
 
 });
 
-Request.JSONP.requests = [];
-
-$extend(MooTools, {
-	logged: [],
-	log: function(){
-		MooTools.logged.push(arguments);
-	}
-});
+Request.JSONP.requests = [];