Issues with the Italo-Turkish War over Libya

[rogerburks]

The main issue: In event 900007 Turks Refuse, the only option is to start war with TUR (Ottoman Empire/Turkey) over Libya as follows:

war = { target = TUR attacker_goal = { casus_belli = liberate_country country = LBY } }

Unfortunately, this method of starting war results in full infamy (12.1 infamy) for the attacker. This occurs in addition to the 3 infamy incurred when the player pursues the event chain towards the war in EVT900002OPTB. The user is not warned of the 12.1 infamy, and it frequently causes ai Italy, and possibly unsuspecting players, to go over the infamy limit.

Ideally, the casus belli should be granted before the war instead of being granted inside the war statement. This results in it being "free" when the war starts. Any merited infamy could then be separately added in the same event, which has the benefit of being in the tooltip such that the user is warned of incurred infamy before pressing the button. However, it seems likely that the 12.1 infamy incurred for liberating Libya is not intended. While 3 infamy is a somewhat cheap cost for two colonies (the average cost without the event chain would be 2.75 + 5.5 for a second added Place in the Sun casus belli during a war), this value can be adjusted if need be.

The second issue: A second issue is that history seems to be not properly served by a liberate_country casus belli here. Historically, Italy treated Libya as a colony instead of a puppet or liberated nation. Additionally, a liberate_country casus belli does not agree with flavor text in the game, which agrees with history, stating:

The other Great Powers are quickly laying claim to the rest of Africa, so it is imperative that we seize this opportunity.

This could have been done because place_in_the_sun is not customarily used with a target, although I think that it can be done to ensure that the war is over Cyrenaica and Tripolitania.

The third issue: Event [900007] removes the cores of CYR and TRI without first checking to see if they exist. This seems unrealistic in the unlikely but possible scenarios where they still exist, and it would prove inconvenient and surprising to a player who is struggling to play as either tag. Ideally, a check should be made, such that cores are not removed for existing tags in this instance.

[rogerburks]

In testing, it seems that place_in_the_sun can be given a target using this method:

	attacker_goal = { casus_belli = place_in_the_sun state_province_id = 1735 }
	attacker_goal = { casus_belli = place_in_the_sun state_province_id = 1731 }

When done in this way, the war fires with valid targets, and colonies are awarded to Italy if it wins.