Skip to content
This repository was archived by the owner on May 22, 2021. It is now read-only.

l10n for .progress-text #349

Closed
yfdyh000 opened this issue Jul 28, 2017 · 3 comments
Closed

l10n for .progress-text #349

yfdyh000 opened this issue Jul 28, 2017 · 3 comments

Comments

@yfdyh000
Copy link
Contributor

The variables order and "of" text.

@pdehaan pdehaan added the l10n label Jul 28, 2017
@ghost
Copy link

ghost commented Jul 28, 2017

Let's localize this! https://github.com/mozilla/send/blob/master/frontend/src/upload.js#L205

Would a / work fine instead of "of" ?

/cc @flodolo to tell us the best way to do this. :)

@ghost ghost added this to the Elegant Eagle (July 28) milestone Jul 28, 2017
@yfdyh000
Copy link
Contributor Author

$('.progress-text').text(
&
$('.progress-text').text(
.

Yes, "/" is fine.

@flodolo
Copy link
Collaborator

flodolo commented Jul 28, 2017

It should be fully localized to allow reordering, something like

// This message is displayed when uploading a file, e.g. "1,3 MB of 10 MB".
uploadStatusMessage = { $size_loaded } of { $size_total }

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants