Skip to content
This repository was archived by the owner on May 22, 2021. It is now read-only.

Feat: Add ability to change the expiration time. #728

Closed
publicarray opened this issue Jan 24, 2018 · 12 comments
Closed

Feat: Add ability to change the expiration time. #728

publicarray opened this issue Jan 24, 2018 · 12 comments

Comments

@publicarray
Copy link

When sharing files due to time-zones and busy life styles. It would be beneficial to allow us to extend the expiration time up-to a few days (say 3 or 5 ?).

My specific use case was to share a coredump for a bug report on GitHub (19mb file) but due to the nature on open-source communities it might take a few days before someone is able to download the file.

@shikhar-scs
Copy link
Contributor

Either we can change it and extend it to a default of 3/4 days OR maybe keep it on the lines of download - limits.
The default time limit can be changed here

send/server/config.js

Lines 53 to 57 in 91dc3aa

expire_seconds: {
format: Number,
default: 86400,
env: 'EXPIRE_SECONDS'
},

OR again, we can build it on the lines of download limits

@publicarray
Copy link
Author

I'm not sure what you are telling me. But on https://send.firefox.com/ where the text reads

The link to your file will expire after 1 download or 24 hours.

the "1 download" is a configurable drop-down. Why not do the same for the expiration time of the "24 hours"?

@shikhar-scs
Copy link
Contributor

shikhar-scs commented Jan 24, 2018

Yeah @publicarray

we can build it on the lines of download limits

meant

the "1 download" is a configurable drop-down. Why not do the same for the expiration time of the "24 hours"?

the other method I proposed was changing the time limit of 86400 seconds which is basically the no. of seconds in a day 😄

@ghost ghost added the feature request label Jan 29, 2018
@ghost ghost added this to the Stretch milestone Jan 29, 2018
@mxschons
Copy link

+1

@filips123
Copy link

Please also add support to change settings of file (no. of downloads, time, password...) after uploading file.
Also add support to set download and time limit to infinity.

@chrisbra
Copy link

I would also welcome such a change.

@timvisee
Copy link
Contributor

timvisee commented Apr 12, 2018

I do think 24 hours is a nice default, although making this changeable after uploading would be a nice addition yeah. This probably won't allow an unlimited download time, as this would prevent 'dead' files from being cleaned up.

Such a change may be implemented though file parameters, using the /api/params endpoint, in the same way a download limit can be set. Setting a maximum lifetime here would allow the server to check whether it should expire.

I don't think such a change would be hard to complement. I guess we've to wait for a response from a Mozilla developer, to confirm a feature like this would be allowed.

@dannycoates what are your thoughts on this?

@dannycoates
Copy link
Contributor

We will likely be adding more options for expiration this summer. It's currently in the project plan. We've temporarily slowed development for the moment but expect to resume full-time in June.

@chrisbra
Copy link

great to hear. Looking forward :)

@dannycoates
Copy link
Contributor

done in vnext

@filips123
Copy link

@dannycoates When will this be available on website?

@dannycoates
Copy link
Contributor

it's available now in beta at https://send2.dev.lcip.org and release should be sometime in February

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants