-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up webgl_animation_multiple example #16105
Comments
@strazdinsg Any interests in doing this? 😇 |
Ah, sorry I had a change of heart and did by myself. Making PR now. |
Thanks for reporting, I did not know about the code style guide. Will know next time :) BTW, I see there is a rule about naming: ConstantsLikeThis. In the file I created CONSTANTS_ARE_LIKE_THIS, probably should be renamed? |
I manually edited because I don't use IDE to write JavaScript. I know some modules use CONSTANT_NAME style, for example |
We could ask @mrdoob why the constant naming rule is so weird, I have not seen ConstantsLikeThis anywhere else. But I know that one should not question coding convention, just use the one that has been decided "by the board" :). @mrdoob, in case there is an error in the style document and you actually meant CONSTANTS_LIKE_THIS, let us know :) |
I don't have a preference. |
I prefer |
Go for it. |
Done |
Description of the problem
webgl_animation_multiple
example doesn't follow Three.js code style.https://github.com/mrdoob/three.js/wiki/Mr.doob's-Code-Style%E2%84%A2
I'm glad if someone cleans up.
Three.js version
Browser
OS
Hardware Requirements (graphics card, VR Device, ...)
The text was updated successfully, but these errors were encountered: