Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Simplify error for wrong getOptionLabel #20103

Merged
merged 4 commits into from
Mar 13, 2020
Merged

[Autocomplete] Simplify error for wrong getOptionLabel #20103

merged 4 commits into from
Mar 13, 2020
+6 −7

Conversation

oliviertassinari
Copy link
Member

Continuation of #20072. For some reason, I couldn't push a patch on the test case, it's strange.

dandv and others added 4 commits March 12, 2020 04:40
@dandv
Simplify error for wrong getOptionLabel return

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
dc0b1e3
@dandv @oliviertassinari
Update packages/material-ui-lab/src/useAutocomplete/useAutocomplete.js

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
f14d826 
Co-Authored-By: Olivier Tassinari <olivier.tassinari@gmail.com>
@dandv
Apply prettier to the change

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e206f8b
@oliviertassinari
patch the test case

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
4761ef8
@oliviertassinari oliviertassinari added new feature New feature or request PR: ready to ship component: autocomplete This is the name of the generic UI component, not the React module! labels Mar 13, 2020
@oliviertassinari oliviertassinari mentioned this pull request Mar 13, 2020
Closed
@oliviertassinari oliviertassinari merged commit e89ddfd into mui:master Mar 13, 2020
@oliviertassinari oliviertassinari deleted the autocomplete-improve-warn branch March 13, 2020 23:10
@oliviertassinari
Copy link
Member Author

@dandv Thank you!

This was referenced Mar 20, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Mar 30, 2020
@oliviertassinari @EsoterikStare
[Autocomplete] Simplify error for wrong getOptionLabel (mui#20103)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
6b3cc7d
This was referenced Apr 10, 2020
Closed
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon

Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliviertassinari @eps1lon @dandv