Skip to content

Commit 1bb4ba0

Browse files
Janpotoliviertassinari
authored andcommitted
[docs] Improve table of contents cmd+click (#18765)
1 parent 3199e0d commit 1bb4ba0

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

docs/src/modules/components/AppTableOfContents.js

+13-1
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,19 @@ export default function AppTableOfContents(props) {
198198
// Corresponds to 10 frames at 60 Hz
199199
useThrottledOnScroll(itemsServer.length > 0 ? findActiveIndex : null, 166);
200200

201-
const handleClick = hash => () => {
201+
const handleClick = hash => event => {
202+
// Ignore click for new tab/new window behavior
203+
if (
204+
event.defaultPrevented ||
205+
event.button !== 0 || // ignore everything but left-click
206+
event.metaKey ||
207+
event.ctrlKey ||
208+
event.altKey ||
209+
event.shiftKey
210+
) {
211+
return;
212+
}
213+
202214
// Used to disable findActiveIndex if the page scrolls due to a click
203215
clickedRef.current = true;
204216
unsetClickedRef.current = setTimeout(() => {

docs/src/modules/components/MarkdownLinks.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ export async function handleEvent(event, as) {
99
event.button !== 0 || // ignore everything but left-click
1010
event.metaKey ||
1111
event.ctrlKey ||
12-
event.shiftKey ||
13-
(event.nativeEvent && event.nativeEvent.which === 2)
12+
event.altKey ||
13+
event.shiftKey
1414
) {
1515
return;
1616
}

0 commit comments

Comments
 (0)