Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snackbar] Enable usage with the Alert #18750

Closed
1 task done
lcswillems opened this issue Dec 8, 2019 · 8 comments · Fixed by #18702
Closed
1 task done

[Snackbar] Enable usage with the Alert #18750

lcswillems opened this issue Dec 8, 2019 · 8 comments · Fixed by #18702
Labels
component: alert This is the name of the generic UI component, not the React module! component: snackbar This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@lcswillems
Copy link
Contributor

lcswillems commented Dec 8, 2019

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

I am implementing the variant property of the snackbar following the example in https://material-ui.com/components/snackbars/ , but I don't understand why it is not builtin?

If it was, it would save me a lot of time.

@oliviertassinari oliviertassinari added component: snackbar This is the name of the generic UI component, not the React module! new feature New feature or request labels Dec 8, 2019
@mbrookes mbrookes added status: waiting for author Issue with insufficient information and removed new feature New feature or request labels Dec 8, 2019
@mbrookes
Copy link
Member

mbrookes commented Dec 8, 2019

@lcswillems What variant example? Do you mean the customised snackbars example?

@oliviertassinari
Copy link
Member

@mbrookes Yes, I think that it's about supporting something similar to https://github.com/iamhosseindhv/notistack.

@lcswillems
Copy link
Contributor Author

Yes, I mean the customised snackbars. Sorry for not having specified which example!

@mbrookes
Copy link
Member

mbrookes commented Dec 9, 2019

Okay, so the variant prop is typically used for Material Design variations (for example Button: contained / text / outline; TextField standard / filled / outlined.

Whilst the customised snackbars are attractive, they're most definitely not spec. The proposed Alert component (while also not spec) seems to serves the same purpose as the customized Snackbar, leaving the snackbar for its intended purpose.

Will this be sufficient if merged?

@lcswillems
Copy link
Contributor Author

lcswillems commented Dec 9, 2019

I don't really understand what is this Alert component. Maybe could I wait it to be merged to tell?

@oliviertassinari
Copy link
Member

@mbrookes Oh, this is an interesting thought, I haven't considered that people could compose the Alert with the Snackbar component to handle the representation part of it. I love the idea!

@oliviertassinari oliviertassinari changed the title Add variant to Snackbar [Snackbar] Enable usage with the Alert Dec 9, 2019
@oliviertassinari oliviertassinari added component: alert This is the name of the generic UI component, not the React module! new feature New feature or request and removed status: waiting for author Issue with insufficient information labels Dec 9, 2019
@dimitropoulos
Copy link
Member

dimitropoulos commented Dec 9, 2019

I don't really understand what is this Alert component.

@lcswillems please consult the list of other implementations here #18094 and let me know if you think it clarifies the purpose of this component.

Screenshot_20191209_113934

@lcswillems
Copy link
Contributor Author

lcswillems commented Dec 9, 2019

Okay I see! It is great! If it can then be embedded in a snackbar, it is perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: alert This is the name of the generic UI component, not the React module! component: snackbar This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants