-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snackbar] Enable usage with the Alert #18750
Comments
@lcswillems What variant example? Do you mean the customised snackbars example? |
@mbrookes Yes, I think that it's about supporting something similar to https://github.com/iamhosseindhv/notistack. |
Yes, I mean the customised snackbars. Sorry for not having specified which example! |
Okay, so the variant prop is typically used for Material Design variations (for example Button: contained / text / outline; TextField standard / filled / outlined. Whilst the customised snackbars are attractive, they're most definitely not spec. The proposed Alert component (while also not spec) seems to serves the same purpose as the customized Snackbar, leaving the snackbar for its intended purpose. Will this be sufficient if merged? |
I don't really understand what is this Alert component. Maybe could I wait it to be merged to tell? |
@mbrookes Oh, this is an interesting thought, I haven't considered that people could compose the Alert with the Snackbar component to handle the representation part of it. I love the idea! |
@lcswillems please consult the list of other implementations here #18094 and let me know if you think it clarifies the purpose of this component. |
Okay I see! It is great! If it can then be embedded in a snackbar, it is perfect! |
Summary 💡
I am implementing the variant property of the snackbar following the example in https://material-ui.com/components/snackbars/ , but I don't understand why it is not builtin?
If it was, it would save me a lot of time.
The text was updated successfully, but these errors were encountered: