fix(iroh-p2p): implement full local lookup
#537
Merged
+136
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously only returning the peer id, external addrs, and listening addrs. We now return the same content as performing a lookup on a remote peer.
ramfox
commented
Nov 21, 2022
Comment on lines
192
to
+214
| fn poll( | ||
| &mut self, | ||
| _cx: &mut Context<'_>, | ||
| _params: &mut impl PollParameters, | ||
| params: &mut impl PollParameters, | ||
| ) -> Poll<NetworkBehaviourAction<Self::OutEvent, Self::ConnectionHandler>> { | ||
| // TODO(ramfox): | ||
| // We can only get the supported protocols of the local node by examining the | ||
| // `PollParameters`, which mean you can only get the supported protocols by examining the | ||
| // `PollParameters` in this method (`poll`) of a network behaviour. | ||
| // I injected this responsibility in the `peer_manager`, because it's the only "simple" | ||
| // network behaviour we have implemented. | ||
| // There is an issue up to remove `PollParameters`, and a discussion into how to instead | ||
| // get the `supported_protocols` of the node: | ||
| // https://github.com/libp2p/rust-libp2p/issues/3124 | ||
| // When that is resolved, we can hopefully remove this responsibility from the `peer_manager`, | ||
| // where it, frankly, doesn't belong. | ||
| if self.supported_protocols.is_empty() { | ||
| self.supported_protocols = params | ||
| .supported_protocols() | ||
| .map(|p| String::from_utf8_lossy(&p).to_string()) | ||
| .collect(); | ||
| } | ||
|
|
There was a problem hiding this comment.
@dignifiedquire would specifically like your eyes on this.
I gave some rationale as to why this is how I decided to proceed, but I'm aware this is an inelegant solution to an inelegant problem.
There was a problem hiding this comment.
seems fine to me, we can just update this code once libp2p provides a better method
dignifiedquire
approved these changes
Nov 22, 2022
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Nov 23, 2022
We were previously only returning the peer id, external addrs, and listening addrs. We now return the same content as performing a lookup on a remote peer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously only returning the peer id, external addrs, and listening addrs. We now return the same content as performing a lookup on a remote peer.
closes n0-computer/beetle#70