Skip to content

Commit 78803e4

Browse files
fix(resolve in updateSource): added missing resolve
Resolve call was missing in `updateSource` both on iOS and Android.
1 parent f339929 commit 78803e4

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/ui-mapbox/index.android.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -2410,7 +2410,7 @@ export class Mapbox extends MapboxCommon implements MapboxApi {
24102410
*
24112411
*/
24122412
updateSource(id: string, options: UpdateSourceOptions, nativeMap?) {
2413-
return new Promise((resolve, reject) => {
2413+
return new Promise<void>((resolve, reject) => {
24142414
try {
24152415
const theMap: com.mapbox.mapboxsdk.maps.MapboxMap = nativeMap || this._mapboxMapInstance;
24162416
if (!theMap) {
@@ -2427,6 +2427,7 @@ export class Mapbox extends MapboxCommon implements MapboxApi {
24272427
case 'geojson':
24282428
const geoJsonString = JSON.stringify(options.data);
24292429
(source as com.mapbox.mapboxsdk.style.sources.GeoJsonSource).setGeoJson(geoJsonString);
2430+
resolve();
24302431
break;
24312432
default:
24322433
reject('Invalid source type: ' + options['type']);

src/ui-mapbox/index.ios.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -2663,7 +2663,7 @@ export class Mapbox extends MapboxCommon implements MapboxApi {
26632663
*
26642664
*/
26652665
updateSource(id: string, options: UpdateSourceOptions, nativeMap?) {
2666-
return new Promise((resolve, reject) => {
2666+
return new Promise<void>((resolve, reject) => {
26672667
try {
26682668
const theMap: MGLMapView = nativeMap || this._mapboxViewInstance;
26692669
if (!theMap) {
@@ -2682,6 +2682,7 @@ export class Mapbox extends MapboxCommon implements MapboxApi {
26822682
const nsData: NSData = content.dataUsingEncoding(NSUTF8StringEncoding);
26832683
const geoJsonShape = MGLShape.shapeWithDataEncodingError(nsData, NSUTF8StringEncoding);
26842684
(source as MGLShapeSource).shape = geoJsonShape;
2685+
resolve();
26852686
break;
26862687
default:
26872688
reject('Invalid source type: ' + options['type']);

0 commit comments

Comments
 (0)