Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deleting accounts from the account resolvers #6559

Open
ripienaar opened this issue Feb 21, 2025 · 4 comments
Open

Improve deleting accounts from the account resolvers #6559

ripienaar opened this issue Feb 21, 2025 · 4 comments
Labels
2.12 needs info Additional info is needed proposal Enhancement idea or proposal

Comments

@ripienaar
Copy link
Contributor

Proposed change

We need to evaluate if current features around deleting accounts are sufficient.

  • Are all assets correctly cleaned up during delete?
  • Does nsc and nats auth have safe ways to delete accounts that properly cleans up the server?
  • Is there sufficient logging and auditing events for deletes?
  • We should also consider audit events and log evens for account pushes

@aricart has thoughts.

Use case

Create mature tooling for removing accounts

Contribution

No response

@ripienaar ripienaar added 2.12 proposal Enhancement idea or proposal needs info Additional info is needed labels Feb 21, 2025
@aricart
Copy link
Member

aricart commented Feb 21, 2025

The PR for #6427 is hanging out there (right now it works with a full resolver, at least on the disk pruning when NOT using leafnodes).

As for the deletion.

  • Need to verify what happens to users when the account is deleted (expecting disconnect, but not verified it)
  • The server typically keeps accounts in memory, need to verify if the account gets released

The typical process for removing an account is usually to set connections to zero, update, hoping that a delete simply kills clients, because then it removes the need to update the account.

@derekcollison
Copy link
Member

Should we look to pull in #6427?

@aricart
Copy link
Member

aricart commented Feb 21, 2025

Server will panic if they do a resolver that deletes, with leafnodes or other things that get messages enriched by additional data.

@aricart
Copy link
Member

aricart commented Feb 21, 2025

Not to be pendantic, but also part of the account removal should be the cleanup of JS assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.12 needs info Additional info is needed proposal Enhancement idea or proposal
Projects
None yet
Development

No branches or pull requests

3 participants