Remove deprecated method Spree::Store.by_url

solidusio#2041

Author: DanielePalombo

core/app/models/spree/store.rb

@@ -25,12 +25,6 @@ class Store < Spree::Base
     before_save :ensure_default_exists_and_is_unique
     before_destroy :validate_not_default
 
-    scope :by_url, lambda { |url| where("url like ?", "%#{url}%") }
-
-    class << self
-      deprecate by_url: "Spree::Store.by_url is DEPRECATED", deprecator: Spree::Deprecation
-    end
-
     def available_locales
       locales = super()
       if locales

core/spec/models/spree/store_spec.rb

@@ -3,30 +3,8 @@
 require 'rails_helper'
 
 RSpec.describe Spree::Store, type: :model do
-  before do
-    allow(Spree::Deprecation).to receive(:warn).
-      with(/^by_url is deprecated and will be removed/, any_args)
-  end
-
   it { is_expected.to respond_to(:cart_tax_country_iso) }
 
-  describe ".by_url (deprecated)" do
-    let!(:store)    { create(:store, url: "website1.com\nwww.subdomain.com") }
-    let!(:store_2)  { create(:store, url: 'freethewhales.com') }
-
-    before do
-      expect(Spree::Deprecation).to receive(:warn).
-        with(/^by_url is deprecated and will be removed/, any_args)
-    end
-
-    it "should find stores by url" do
-      by_domain = Spree::Store.by_url('www.subdomain.com')
-
-      expect(by_domain).to include(store)
-      expect(by_domain).not_to include(store_2)
-    end
-  end
-
   describe ".default" do
     it "should ensure saved store becomes default if one doesn't exist yet" do
       expect(Spree::Store.where(default: true).count).to eq(0)