-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop the dependency of System.Security.Cryptography
#3235
Comments
according to the official document of dotnet at https://learn.microsoft.com/en-us/dotnet/standard/security/cross-platform-cryptography, it is said that:
and for ECDSA
since different platforms use different cryptography implementations, their behavior is not consistent. |
See dotnet/runtime#20342 and dotnet/runtime#84132 for support SHA3 they added alot. Its just the Operating system doesn't support it yet. Only You can use |
@cschuchardt88 I don’t think as a blockchain platform, it is tolerated to behave differently on different platforms. it just no one knows how if you search something like behavior is not consistent across platforms on dotnet runtime github repo there's multiple issues related |
@vang1ong7ang I understand your concern, but how do we know if the new lib we use does not have that problem? |
I say we implement it our self. |
that's a problem to be honest. the consistency is not promised by BouncyCastle. but seems BouncyCastle does better |
Already moved to Bouncy Castle |
in the discussion of #3220 it is tried to explore the possibility of moving to BouncyCastle
for performance reasons, many prefer keeping
System.Security.Cryptography
instead of moving to BouncyCastlehowever, I don't think this is a rational decision
the only reason is that:
System.Security.Cryptography
behaves inconsistently across platforms and it may lead to FORKThe text was updated successfully, but these errors were encountered: