feat: add normalize path to http adapter

Author: kamilmysliwiec

packages/common/interfaces/http/http-server.interface.ts

@@ -102,4 +102,5 @@ export interface HttpServer<
     version: VersionValue,
     versioningOptions: VersioningOptions,
   ): (req: TRequest, res: TResponse, next: () => void) => Function;
+  normalizePath?(path: string): string;
 }

packages/core/adapters/http-adapter.ts

@@ -143,6 +143,10 @@ export abstract class AbstractHttpAdapter<
     return this.instance as T;
   }
 
+  public normalizePath(path: string): string {
+    return path;
+  }
+
   abstract close();
   abstract initHttpServer(options: NestApplicationOptions);
   abstract useStaticAssets(...args: any[]);
@@ -158,11 +162,7 @@ export abstract class AbstractHttpAdapter<
   abstract setErrorHandler(handler: Function, prefix?: string);
   abstract setNotFoundHandler(handler: Function, prefix?: string);
   abstract isHeadersSent(response: any);
-  // TODO remove optional signature (v11)
-  abstract getHeader?(response: any, name: string);
   abstract setHeader(response: any, name: string, value: string);
-  // TODO remove optional signature (v11)
-  abstract appendHeader?(response: any, name: string, value: string);
   abstract registerParserMiddleware(prefix?: string, rawBody?: boolean);
   abstract enableCors(
     options: CorsOptions | CorsOptionsDelegate<TRequest>,

packages/core/router/router-explorer.ts

@@ -39,7 +39,6 @@ import { MetadataScanner } from '../metadata-scanner';
 import { PipesConsumer, PipesContextCreator } from '../pipes';
 import { ExceptionsFilter } from './interfaces/exceptions-filter.interface';
 import { RoutePathMetadata } from './interfaces/route-path-metadata.interface';
-import { LegacyRouteConverter } from './legacy-route-converter';
 import { PathsExplorer } from './paths-explorer';
 import { REQUEST_CONTEXT_ID } from './request/request-constants';
 import { RouteParamsFactory } from './route-params-factory';
@@ -232,15 +231,10 @@ export class RouterExplorer {
         };
 
         this.copyMetadataToCallback(targetCallback, routeHandler);
-        try {
-          const convertedPath = LegacyRouteConverter.tryConvert(path);
-          routerMethodRef(convertedPath, routeHandler);
-        } catch (e) {
-          if (e instanceof TypeError) {
-            LegacyRouteConverter.printError(path);
-          }
-          throw e;
-        }
+        const normalizedPath = router.normalizePath
+          ? router.normalizePath(path)
+          : path;
+        routerMethodRef(normalizedPath, routeHandler);
 
         this.graphInspector.insertEntrypointDefinition<HttpEntrypointMetadata>(
           entrypointDefinition,

packages/platform-express/adapters/express-adapter.ts

@@ -144,18 +144,30 @@ export class ExpressAdapter extends AbstractHttpAdapter<
     return response.headersSent;
   }
 
-  public getHeader?(response: any, name: string) {
+  public getHeader(response: any, name: string) {
     return response.get(name);
   }
 
   public setHeader(response: any, name: string, value: string) {
     return response.set(name, value);
   }
 
-  public appendHeader?(response: any, name: string, value: string) {
+  public appendHeader(response: any, name: string, value: string) {
     return response.append(name, value);
   }
 
+  public normalizePath(path: string): string {
+    try {
+      const convertedPath = LegacyRouteConverter.tryConvert(path);
+      return convertedPath;
+    } catch (e) {
+      if (e instanceof TypeError) {
+        LegacyRouteConverter.printError(path);
+      }
+      throw e;
+    }
+  }
+
   public listen(port: string | number, callback?: () => void): Server;
   public listen(
     port: string | number,