fix: normalize middle wildcards, call path-to-regexp early

Author: kamilmysliwiec

packages/core/router/legacy-route-converter.ts

@@ -14,7 +14,7 @@ export class LegacyRouteConverter {
    * @returns The converted route, or the original route if it cannot be converted.
    */
   static tryConvert(route: string): string {
-    // Normalize path to eliminate additional conditions.
+    // Normalize path to eliminate additional if statements.
     const routeWithLeadingSlash = route.startsWith('/') ? route : `/${route}`;
     const normalizedRoute = route.endsWith('/')
       ? routeWithLeadingSlash
@@ -27,17 +27,29 @@ export class LegacyRouteConverter {
       }
       return route.replace('(.*)', '{*path}');
     }
+
     if (normalizedRoute.endsWith('/*/')) {
       // Skip printing warning for the "all" wildcard.
       if (normalizedRoute !== '/*/') {
         this.printWarning(route);
       }
       return route.replace('*', '{*path}');
     }
+
     if (normalizedRoute.endsWith('/+/')) {
       this.printWarning(route);
       return route.replace('/+', '/*path');
     }
+
+    // When route includes any wildcard segments in the middle.
+    if (normalizedRoute.includes('/*/')) {
+      this.printWarning(route);
+      // Replace each /*/ segment with a named parameter using different name for each segment.
+      return route.replaceAll('/*/', (match, offset) => {
+        return `/*path${offset}/`;
+      });
+    }
+
     return route;
   }
 
@@ -47,7 +59,7 @@ export class LegacyRouteConverter {
 
   static printWarning(route: string): void {
     this.logger.warn(
-      UNSUPPORTED_PATH_MESSAGE`${route}` + ' Attempting to convert...',
+      UNSUPPORTED_PATH_MESSAGE`${route}` + ' Attempting to auto-convert...',
     );
   }
 }

packages/platform-express/adapters/express-adapter.ts

@@ -34,6 +34,7 @@ import * as express from 'express';
 import type { Server } from 'http';
 import * as http from 'http';
 import * as https from 'https';
+import { pathToRegexp } from 'path-to-regexp';
 import { Duplex, pipeline } from 'stream';
 import { NestExpressBodyParserOptions } from '../interfaces/nest-express-body-parser-options.interface';
 import { NestExpressBodyParserType } from '../interfaces/nest-express-body-parser.interface';
@@ -159,6 +160,8 @@ export class ExpressAdapter extends AbstractHttpAdapter<
   public normalizePath(path: string): string {
     try {
       const convertedPath = LegacyRouteConverter.tryConvert(path);
+      // Call "pathToRegexp" to trigger a TypeError if the path is invalid
+      pathToRegexp(convertedPath);
       return convertedPath;
     } catch (e) {
       if (e instanceof TypeError) {