Skip to content

Commit db2a9b5

Browse files
chore: resolve conflicts
2 parents c42d235 + 8af7183 commit db2a9b5

File tree

8 files changed

+30
-39
lines changed

8 files changed

+30
-39
lines changed

integration/cors/e2e/fastify.spec.ts

+6-4
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,12 @@ describe.skip('Fastify Cors', () => {
3838
);
3939

4040
let requestId = 0;
41-
const configDelegation = function (req, cb) {
42-
const config = configs[requestId];
43-
requestId++;
44-
cb(null, config);
41+
const configDelegation = {
42+
delegator: function (req, cb) {
43+
const config = configs[requestId];
44+
requestId++;
45+
cb(null, config);
46+
},
4547
};
4648
app.enableCors(configDelegation);
4749

packages/common/interfaces/http/http-server.interface.ts

+2-6
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
import { RequestMethod } from '../../enums';
2-
import {
3-
CorsOptions,
4-
CorsOptionsDelegate,
5-
} from '../../interfaces/external/cors-options.interface';
62
import { NestApplicationOptions } from '../../interfaces/nest-application-options.interface';
7-
import { VersioningOptions, VersionValue } from '../version-options.interface';
3+
import { VersionValue, VersioningOptions } from '../version-options.interface';
84

95
export type ErrorHandler<TRequest = any, TResponse = any> = (
106
error: any,
@@ -91,7 +87,7 @@ export interface HttpServer<
9187
getRequestUrl?(request: TRequest): string;
9288
getInstance(): ServerInstance;
9389
registerParserMiddleware(...args: any[]): any;
94-
enableCors(options: CorsOptions | CorsOptionsDelegate<TRequest>): any;
90+
enableCors(options: any): any;
9591
getHttpServer(): any;
9692
initHttpServer(options: NestApplicationOptions): void;
9793
close(): any;

packages/common/interfaces/nest-application.interface.ts

+1-5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
import {
2-
CorsOptions,
3-
CorsOptionsDelegate,
4-
} from './external/cors-options.interface';
51
import { CanActivate } from './features/can-activate.interface';
62
import { NestInterceptor } from './features/nest-interceptor.interface';
73
import { GlobalPrefixOptions } from './global-prefix-options.interface';
@@ -36,7 +32,7 @@ export interface INestApplication<TServer = any>
3632
*
3733
* @returns {void}
3834
*/
39-
enableCors(options?: CorsOptions | CorsOptionsDelegate<any>): void;
35+
enableCors(options?: any): void;
4036

4137
/**
4238
* Enables Versioning for the application.

packages/core/adapters/http-adapter.ts

+1-8
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
import { HttpServer, RequestMethod, VersioningOptions } from '@nestjs/common';
22
import { RequestHandler, VersionValue } from '@nestjs/common/interfaces';
3-
import {
4-
CorsOptions,
5-
CorsOptionsDelegate,
6-
} from '@nestjs/common/interfaces/external/cors-options.interface';
73
import { NestApplicationOptions } from '@nestjs/common/interfaces/nest-application-options.interface';
84

95
/**
@@ -164,10 +160,7 @@ export abstract class AbstractHttpAdapter<
164160
abstract isHeadersSent(response: any);
165161
abstract setHeader(response: any, name: string, value: string);
166162
abstract registerParserMiddleware(prefix?: string, rawBody?: boolean);
167-
abstract enableCors(
168-
options: CorsOptions | CorsOptionsDelegate<TRequest>,
169-
prefix?: string,
170-
);
163+
abstract enableCors(options?: any, prefix?: string);
171164
abstract createMiddlewareFactory(
172165
requestMethod: RequestMethod,
173166
):

packages/core/nest-application.ts

+2-8
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@ import {
1515
GlobalPrefixOptions,
1616
NestApplicationOptions,
1717
} from '@nestjs/common/interfaces';
18-
import {
19-
CorsOptions,
20-
CorsOptionsDelegate,
21-
} from '@nestjs/common/interfaces/external/cors-options.interface';
2218
import { Logger } from '@nestjs/common/services/logger.service';
2319
import { loadPackage } from '@nestjs/common/utils/load-package.util';
2420
import {
@@ -129,9 +125,7 @@ export class NestApplication
129125
if (!passCustomOptions) {
130126
return this.enableCors();
131127
}
132-
return this.enableCors(
133-
this.appOptions.cors as CorsOptions | CorsOptionsDelegate<any>,
134-
);
128+
return this.enableCors(this.appOptions.cors);
135129
}
136130

137131
public createServer<T = any>(): T {
@@ -279,7 +273,7 @@ export class NestApplication
279273
return this;
280274
}
281275

282-
public enableCors(options?: CorsOptions | CorsOptionsDelegate<any>): void {
276+
public enableCors(options?: any): void {
283277
this.httpAdapter.enableCors(options!);
284278
}
285279

packages/platform-express/interfaces/nest-express-application.interface.ts

+8-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
1-
import { INestApplication, HttpServer } from '@nestjs/common';
1+
import { HttpServer, INestApplication } from '@nestjs/common';
2+
import type {
3+
CorsOptions,
4+
CorsOptionsDelegate,
5+
} from '@nestjs/common/interfaces/external/cors-options.interface';
6+
import type { Express } from 'express';
27
import type { Server as CoreHttpServer } from 'http';
38
import type { Server as CoreHttpsServer } from 'https';
4-
import type { Express } from 'express';
59
import { NestExpressBodyParserOptions } from './nest-express-body-parser-options.interface';
610
import { NestExpressBodyParserType } from './nest-express-body-parser.interface';
711
import { ServeStaticOptions } from './serve-static-options.interface';
@@ -86,6 +90,8 @@ export interface NestExpressApplication<
8690
*/
8791
useStaticAssets(path: string, options?: ServeStaticOptions): this;
8892

93+
enableCors(options?: CorsOptions | CorsOptionsDelegate<any>): void;
94+
8995
/**
9096
* Register Express body parsers on the fly. Will respect
9197
* the application's `rawBody` option.

packages/platform-fastify/adapters/fastify-adapter.ts

+2-6
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* eslint-disable @typescript-eslint/no-floating-promises */
1+
import { FastifyCorsOptions } from '@fastify/cors';
22
import {
33
HttpStatus,
44
Logger,
@@ -10,10 +10,6 @@ import {
1010
VersioningType,
1111
} from '@nestjs/common';
1212
import { VersionValue } from '@nestjs/common/interfaces';
13-
import {
14-
CorsOptions,
15-
CorsOptionsDelegate,
16-
} from '@nestjs/common/interfaces/external/cors-options.interface';
1713
import { loadPackage } from '@nestjs/common/utils/load-package.util';
1814
import { isString, isUndefined } from '@nestjs/common/utils/shared.utils';
1915
import { AbstractHttpAdapter } from '@nestjs/core/adapters/http-adapter';
@@ -554,7 +550,7 @@ export class FastifyAdapter<
554550
return this.getRequestOriginalUrl(request.raw || request);
555551
}
556552

557-
public enableCors(options: CorsOptions | CorsOptionsDelegate<TRequest>) {
553+
public enableCors(options?: FastifyCorsOptions) {
558554
this.register(
559555
import('@fastify/cors') as Parameters<TInstance['register']>[0],
560556
options,

packages/platform-fastify/interfaces/nest-fastify-application.interface.ts

+8
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { FastifyCorsOptions } from '@fastify/cors';
12
import { HttpServer, INestApplication } from '@nestjs/common';
23
import {
34
FastifyBodyParser,
@@ -75,6 +76,13 @@ export interface NestFastifyApplication<
7576
*/
7677
useStaticAssets(options: FastifyStaticOptions): this;
7778

79+
/**
80+
* Enables CORS (Cross-Origin Resource Sharing)
81+
*
82+
* @returns {void}
83+
*/
84+
enableCors(options?: FastifyCorsOptions): void;
85+
7886
/**
7987
* Sets a view engine for templates (views), for example: `pug`, `handlebars`, or `ejs`.
8088
*

0 commit comments

Comments
 (0)